* [PATCH] dtc: Remove -O dtbo support
@ 2021-03-11 9:49 Masahiro Yamada
[not found] ` <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-03-11 9:49 UTC (permalink / raw)
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA, David Gibson
Cc: Rob Herring, Viresh Kumar, Masahiro Yamada
This partially reverts 163f0469bf2e ("dtc: Allow overlays to have
.dtbo extension").
I think accepting "dtbo" as --out-format is strange. This is not
shown by --help, at least.
*.dtb and *.dtbo should have the same format, "dtb".
Signed-off-by: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
dtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/dtc.c b/dtc.c
index 838c5df..3962d3f 100644
--- a/dtc.c
+++ b/dtc.c
@@ -359,8 +359,6 @@ int main(int argc, char *argv[])
#endif
} else if (streq(outform, "dtb")) {
dt_to_blob(outf, dti, outversion);
- } else if (streq(outform, "dtbo")) {
- dt_to_blob(outf, dti, outversion);
} else if (streq(outform, "asm")) {
dt_to_asm(outf, dti, outversion);
} else if (streq(outform, "null")) {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] dtc: Remove -O dtbo support [not found] ` <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> @ 2021-03-12 1:58 ` David Gibson 0 siblings, 0 replies; 2+ messages in thread From: David Gibson @ 2021-03-12 1:58 UTC (permalink / raw) To: Masahiro Yamada Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Viresh Kumar [-- Attachment #1: Type: text/plain, Size: 1275 bytes --] On Thu, Mar 11, 2021 at 06:49:55PM +0900, Masahiro Yamada wrote: > This partially reverts 163f0469bf2e ("dtc: Allow overlays to have > .dtbo extension"). > > I think accepting "dtbo" as --out-format is strange. This is not > shown by --help, at least. > > *.dtb and *.dtbo should have the same format, "dtb". > > Signed-off-by: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Oops, yes. When reviewing 163f0469bf2e I missed the fact that it accepted -O dtbo as well changing the default based on file extension. Applied. > --- > > dtc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/dtc.c b/dtc.c > index 838c5df..3962d3f 100644 > --- a/dtc.c > +++ b/dtc.c > @@ -359,8 +359,6 @@ int main(int argc, char *argv[]) > #endif > } else if (streq(outform, "dtb")) { > dt_to_blob(outf, dti, outversion); > - } else if (streq(outform, "dtbo")) { > - dt_to_blob(outf, dti, outversion); > } else if (streq(outform, "asm")) { > dt_to_asm(outf, dti, outversion); > } else if (streq(outform, "null")) { -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-12 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-11 9:49 [PATCH] dtc: Remove -O dtbo support Masahiro Yamada
[not found] ` <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-03-12 1:58 ` David Gibson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).