[PATCH] checks: Fix bus-range check

[PATCH] checks: Fix bus-range check

[Thierry Reding]

From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

The upper limit of the bus-range is specified by the second cell of the
bus-range property.

Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 checks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks.c b/checks.c
index e2690e90f90c..fb3fc9cda4b1 100644
--- a/checks.c
+++ b/checks.c
@@ -892,7 +892,7 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
 	} else {
 		cells = (cell_t *)prop->val.val;
 		min_bus = fdt32_to_cpu(cells[0]);
-		max_bus = fdt32_to_cpu(cells[0]);
+		max_bus = fdt32_to_cpu(cells[1]);
 	}
 	if ((bus_num < min_bus) || (bus_num > max_bus))
 		FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",
-- 
2.32.0

Re: [PATCH] checks: Fix bus-range check

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On Tue, Jun 29, 2021 at 01:43:04PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> The upper limit of the bus-range is specified by the second cell of the
> bus-range property.
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Applied, thanks.

> ---
>  checks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/checks.c b/checks.c
> index e2690e90f90c..fb3fc9cda4b1 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -892,7 +892,7 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
>  	} else {
>  		cells = (cell_t *)prop->val.val;
>  		min_bus = fdt32_to_cpu(cells[0]);
> -		max_bus = fdt32_to_cpu(cells[0]);
> +		max_bus = fdt32_to_cpu(cells[1]);
>  	}
>  	if ((bus_num < min_bus) || (bus_num > max_bus))
>  		FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]