From: Ayush Singh <ayush@beagleboard.org>
To: d-gole@ti.com, lorforlinux@beagleboard.org,
jkridner@beagleboard.org, robertcnelson@beagleboard.org,
nenad.marinkovic@mikroe.com, Andrew Davis <afd@ti.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Robert Nelson <robertcnelson@gmail.com>
Cc: devicetree-compiler@vger.kernel.org,
Ayush Singh <ayush@beagleboard.org>,
Simon Glass <sjg@chromium.org>
Subject: [PATCH v3 0/2] Add capability to append to property
Date: Mon, 11 Nov 2024 15:24:32 +0530 [thread overview]
Message-ID: <20241111-append-v3-0-609c09401f3f@beagleboard.org> (raw)
Allow appending values to a property instead of overriding the previous
values of property.
Currently, we have /delete-node/ and /delete-property/, but lack
/append-property/. Hence we end up having to repeat all existing values
when appending to a property (e.g. see [1] appending to clocks from
[2]).
This functionality is also important for creating a device tree based
implementation to support different types of addon-boards such as
mikroBUS, Grove [3], etc.
In practice, it looks as follows:
```
dts-v1/;
/ {
str-prop = "0";
};
/ {
/append-property/ str-prop = "1";
};
```
Open items
- Appending to non-existent property:
I think it is better to create a new property if the property does not
exist instead of giving an error.
If the default is an error, then the condition, "create a property if
it does not exist, else append" cannot be expressed. I think this
behaviour is desirable with more complex overlays required for
supporting addon boards using devicetree.
[3] https://lore.kernel.org/linux-arm-kernel/20240702164403.29067-1-afd@ti.com/
[2] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts#L39
[1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L3334
Signed-off-by: Ayush Singh <ayush@beagleboard.org>
---
Changes in v3:
- Add support for annotations. Works similar to nodes (since they
already append by default).
- Link to v2: https://lore.kernel.org/r/20240830-append-v2-0-ec1e03f110ad@beagleboard.org
Changes in v2:
- Add comment for append struct member.
- Small code improvements
- Improve test
- Link to v1: https://lore.kernel.org/r/20240827-append-v1-0-d7a126ef1be3@beagleboard.org
---
Ayush Singh (2):
dtc: Add /append-property/
tests: Add test for append-property
dtc-lexer.l | 7 +++++++
dtc-parser.y | 6 ++++++
dtc.h | 5 +++++
livetree.c | 36 +++++++++++++++++++++++++++++-------
tests/append_prop.dts | 21 +++++++++++++++++++++
tests/run_tests.sh | 7 +++++++
6 files changed, 75 insertions(+), 7 deletions(-)
---
base-commit: 99031e3a4a6e479466ae795790b44727434ca27d
change-id: 20240827-append-f614fe3261f9
Best regards,
--
Ayush Singh <ayush@beagleboard.org>
next reply other threads:[~2024-11-11 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 9:54 Ayush Singh [this message]
2024-11-11 9:54 ` [PATCH v3 1/2] dtc: Add /append-property/ Ayush Singh
2024-11-15 4:07 ` Dhruva Gole
2024-11-11 9:54 ` [PATCH v3 2/2] tests: Add test for append-property Ayush Singh
2024-12-04 13:29 ` [PATCH v3 0/2] Add capability to append to property Ayush Singh
2024-12-10 15:34 ` Andreas Gnau
2024-12-11 4:51 ` Ayush Singh
2024-12-16 6:09 ` David Gibson
2024-12-20 15:30 ` Ayush Singh
2024-12-26 6:54 ` David Gibson
2024-12-26 11:10 ` Geert Uytterhoeven
2024-12-27 4:05 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111-append-v3-0-609c09401f3f@beagleboard.org \
--to=ayush@beagleboard.org \
--cc=afd@ti.com \
--cc=d-gole@ti.com \
--cc=devicetree-compiler@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jkridner@beagleboard.org \
--cc=lorforlinux@beagleboard.org \
--cc=nenad.marinkovic@mikroe.com \
--cc=robertcnelson@beagleboard.org \
--cc=robertcnelson@gmail.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).