From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Gibson <david@gibson.dropbear.id.au>,
devicetree-compiler@vger.kernel.org,
Ayush Singh <ayush@beagleboard.org>
Subject: [PATCH] libfdt: Drop including string.h from libfdt_internal.h
Date: Mon, 11 Aug 2025 08:04:16 -0500 [thread overview]
Message-ID: <20250811130416.2653959-1-robh@kernel.org> (raw)
Commit 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()") added a
string.h include to libfdt_internal.h which introduces a libc dependency
which cannot be overridden. Environments without libc (e.g. Linux
kernel) use a custom libfdt_env.h. string.h is already indirectly
included in libfdt_env.h, so it can be dropped from libfdt_internal.h.
Fixes: 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
libfdt/libfdt_internal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index 773bba87bc6e..b60b5456f596 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -6,7 +6,6 @@
* Copyright (C) 2006 David Gibson, IBM Corporation.
*/
#include <fdt.h>
-#include <string.h>
#define FDT_ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1))
#define FDT_TAGALIGN(x) (FDT_ALIGN((x), FDT_TAGSIZE))
--
2.47.2
next reply other threads:[~2025-08-11 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 13:04 Rob Herring (Arm) [this message]
2025-08-11 19:57 ` [PATCH] libfdt: Drop including string.h from libfdt_internal.h Simon Glass
2025-08-13 1:29 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811130416.2653959-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=ayush@beagleboard.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).