From: Herve Codina <herve.codina@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 4/4] fdtput: Name the property when it cannot be deleted
Date: Wed, 28 Oct 2026 22:18:34 +0100 [thread overview]
Message-ID: <20261028221834.4d69678d@bootlin.com> (raw)
In-Reply-To: <20261028073440.3327687-5-sjg@chromium.org>
Hi Simon,
On Wed, 28 Oct 2026 01:34:20 -0600
Simon Glass <sjg@chromium.org> wrote:
> When 'fdtput -d' fails to delete a property, for example because it does
> not exist, the error names the node rather than the property:
>
> $ fdtput -d test.dtb /chosen missing
> Error at '/chosen': FDT_ERR_NOTFOUND
>
> This suggests that the node is missing, when it is the property that
> is.
>
> Report the property name as well as the node:
>
> $ fdtput -d test.dtb /chosen missing
> Error at '/chosen', property 'missing': FDT_ERR_NOTFOUND
>
> Check the message in the existing test for this.
>
> Fixes: aa719618a8b7 ("fdtput: add delete node and property function")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
This patch will depends on discussion on previous one.
If test wrappers introduced previously are accepted (IHMO again, they are
good), for this current patch:
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2026-10-28 21:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 7:34 [PATCH v2 0/4] fdtput: Make it clearer how to create nodes Simon Glass
2026-10-28 7:34 ` [PATCH v2 1/4] fdtput: Require a leading '/' with -p Simon Glass
2026-10-28 20:14 ` Herve Codina
2026-10-29 2:07 ` David Gibson
2026-10-29 6:44 ` Simon Glass
2026-10-28 7:34 ` [PATCH v2 2/4] fdtput: Follow an alias when creating nodes " Simon Glass
2026-10-28 20:34 ` Herve Codina
2026-10-28 7:34 ` [PATCH v2 3/4] fdtput: Suggest -p when a node is missing Simon Glass
2026-10-28 21:08 ` Herve Codina
2026-10-29 2:02 ` David Gibson
2026-10-28 7:34 ` [PATCH v2 4/4] fdtput: Name the property when it cannot be deleted Simon Glass
2026-10-28 21:18 ` Herve Codina [this message]
2026-10-29 2:06 ` [PATCH v2 0/4] fdtput: Make it clearer how to create nodes David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028221834.4d69678d@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox