From: Herve Codina <herve.codina@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 4/6] tests: Allow dtc-fatal.sh to check the error message
Date: Thu, 29 Oct 2026 08:21:16 +0100 [thread overview]
Message-ID: <20261029082116.20418e67@bootlin.com> (raw)
In-Reply-To: <20261028093620.3705074-5-sjg@chromium.org>
Hi Simon,
On Wed, 28 Oct 2026 03:36:11 -0600
Simon Glass <sjg@chromium.org> wrote:
> dtc-fatal.sh only checks that dtc exits with status 1, so a test which
> expects a particular error passes just as well if dtc fails for some
> other reason, such as a mistake in the test's dts file.
>
> Add a -m option which also checks that dtc's output contains a given
> message. Use it for the nonexist-node-ref2 test.
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
On an other series which has been applied [1], new wrappers wrap_error_msg()
and run_wrap_error_msg_test() [2].
Those wrappers allow to check error messages.
It would be nice to have dtc-fatal.sh feature benefit of those wrappers
probably even removing the dtc-fatal.sh script itself.
[1]: https://lore.kernel.org/devicetree-compiler/auKqGJdeg-SZS_tp@gractus.seuss/
[2]: https://lore.kernel.org/devicetree-compiler/auKpLvtbaWufFMSr@gractus.seuss/
Best regards,
Hervé
next prev parent reply other threads:[~2026-10-29 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:36 [PATCH v2 0/6] dtc: Fix deletes within a section and before a redefinition Simon Glass
2026-10-28 9:36 ` [PATCH v2 1/6] dtc: Apply deletes in the section which has them Simon Glass
2026-10-28 9:36 ` [PATCH v2 2/6] dtc: Remove a deleted node or property from the tree Simon Glass
2026-10-28 9:36 ` [PATCH v2 3/6] dtc: Clarify when delete placeholders are dropped Simon Glass
2026-10-28 17:56 ` Herve Codina
2026-10-28 9:36 ` [PATCH v2 4/6] tests: Allow dtc-fatal.sh to check the error message Simon Glass
2026-10-28 18:02 ` Herve Codina
2026-10-29 7:21 ` Herve Codina [this message]
2026-10-28 9:36 ` [PATCH v2 5/6] dtc: Report an error for a delete in an overlay fragment Simon Glass
2026-10-28 18:17 ` Herve Codina
2026-10-28 9:36 ` [PATCH v2 6/6] doc: dts-format: Describe later definitions and deletes Simon Glass
2026-10-28 18:25 ` Herve Codina
2026-10-29 2:49 ` [PATCH v2 0/6] dtc: Fix deletes within a section and before a redefinition David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029082116.20418e67@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox