From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
Subject: Re: [PATCH 3/3 v2] annotations: add the annotation functionality
Date: Tue, 16 Jan 2018 20:17:43 -0800 [thread overview]
Message-ID: <3ba34256-9442-5177-90db-0a180728e05b@gmail.com> (raw)
In-Reply-To: <4f3eda57-e50b-922b-0b02-d5859aedda71-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Julia,
When I was creating the sample output for this reply to David,
I noticed that the --annotate-full annotation for the dtc
generated content (eg the phandle properties) are reporting
"/* <no-file>:<no-line> */". Did you intend to remove this,
as you did for the --annotate-full case?
-Frank
On 01/16/18 20:13, Frank Rowand wrote:
> On 01/16/18 17:13, David Gibson wrote:
>> On Mon, Jan 15, 2018 at 07:24:10PM +0100, Julia Lawall wrote:
>>> This commit provides two new command-line options:
>>>
>>> --annotate (abbreviated -T)
>>> --annotate-full (abbreviated -F)
>>
>> What's the rationale for having two different versions of the
>> annotations?
>
> I'll put an example to try to explain, at the end of this email.
>
< snip >
next prev parent reply other threads:[~2018-01-17 4:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 18:24 [PATCH 0/3 v2] annotations Julia Lawall
[not found] ` <1516040650-9848-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2018-01-15 18:24 ` [PATCH 1/3 v2] annotations: check for NULL position Julia Lawall
[not found] ` <1516040650-9848-2-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2018-01-17 1:10 ` David Gibson
2018-01-15 18:24 ` [PATCH 2/3 v2] annotations: add positions Julia Lawall
[not found] ` <1516040650-9848-3-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2018-01-17 0:50 ` David Gibson
2018-01-15 18:24 ` [PATCH 3/3 v2] annotations: add the annotation functionality Julia Lawall
[not found] ` <1516040650-9848-4-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2018-01-17 1:13 ` David Gibson
[not found] ` <20180117011322.GW30352-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2018-01-17 4:13 ` Frank Rowand
[not found] ` <4f3eda57-e50b-922b-0b02-d5859aedda71-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-17 4:17 ` Frank Rowand [this message]
[not found] ` <3ba34256-9442-5177-90db-0a180728e05b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-17 5:50 ` Julia Lawall
2018-01-17 6:11 ` Frank Rowand
[not found] ` <5fefdac4-87f7-de50-ff39-1911337a2a2e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-17 6:13 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba34256-9442-5177-90db-0a180728e05b@gmail.com \
--to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Julia.Lawall-L2FTfq7BK8M@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frank.rowand-7U/KSKJipcs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).