Re: [PATCH v2 1/2] Makefile: deprecate in favor of Meson

[Eli Schwartz <eschwartz93@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1491 bytes --]

On 4/30/25 10:56 AM, David Gibson wrote:
>> +$(warning WARNING: Building dtc using the Makefile is deprecated, in favor of using the Meson build system instead.)
>> +$(warning )
>> +$(warning https://mesonbuild.com)
> 
> For succinctness, I suggest:
> 
> WARNING: Building dtc using make is deprecated in favour of using Meson (https://mesonbuild.com)
> 
> Note that British/Australian spelling is preferred for this project, hence "favour".


Yup, sounds reasonable. :)


>> +$(warning )
>> +$(warning Use `meson setup builddir/ && ninja -C builddir/` to build, or `meson configure` to see build options.)
> 
> I'd prefer to suggest "meson compile -C builddir" here, rather than
> directly invoking ninja, and I'd also like to list "meson test -C
> builddir" as the replacement for "make check".


As you wish, of course. But note that "meson compile" is a dispatching
command that first checks whether the build has been setup using a
non-default --backend option instead of the default ninja:

- Microsoft msbuild
- Apple xcode

and then determines which of the three to run. So if you decide to run
"meson compile -C builddir/" it will just in turn run, on your behalf,
"ninja -C builddir/".

It also has the side effect of, if your compiler is MSVC cl.exe, loading
vcvarsall.bat before dispatching to ninja, as a workaround for

https://github.com/ninja-build/ninja/issues/1610

None of that matters for dtc, I guess. :)



-- 
Eli Schwartz

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]