Re: [PATCH] srcpos: correct column numbers

[Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 01/15/18 10:33, Julia Lawall wrote:
> The start of a line is column 0, at least according to emacs.

According to vim, the first character of a line is column 1.  I don't know
if it has a concept of column 0, to the left of that character.

$ vim --version
VIM - Vi IMproved 7.4

Let the editor wars begin.... :-)

Personally, I use vim, but if the dtc column numbers match emac's world view
instead of vim's, that is fine with me.

-Frank

> 
> Every character counts, so need to increment by 1 before adjusting for tab.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
> ---
>  srcpos.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/srcpos.c b/srcpos.c
> index 9d38459..e8fced9 100644
> --- a/srcpos.c
> +++ b/srcpos.c
> @@ -154,7 +154,7 @@ void srcfile_push(const char *fname)
>  	srcfile->prev = current_srcfile;
> 
>  	srcfile->lineno = 1;
> -	srcfile->colno = 1;
> +	srcfile->colno = 0;
> 
>  	current_srcfile = srcfile;
>  }
> @@ -223,8 +223,9 @@ void srcpos_update(struct srcpos *pos, const char *text, int len)
>  	for (i = 0; i < len; i++)
>  		if (text[i] == '\n') {
>  			current_srcfile->lineno++;
> -			current_srcfile->colno = 1;
> +			current_srcfile->colno = 0;
>  		} else if (text[i] == '\t') {
> +			current_srcfile->colno++;
>  			current_srcfile->colno =
>  				ALIGN(current_srcfile->colno, TAB_SIZE);
>  		} else {
>