coverage test failed

coverage test failed

[Benjamin Bimmermann]

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

Hi Simon,

I have created a patch for the test_tree1.dts. If you run "coverage run 
pylibfdt_tests.py" with that patch you see the error:

ERROR: testGetProperty (__main__.PyLibfdtTests)
Check that we can read the details of a property
----------------------------------------------------------------------
Traceback (most recent call last):
   File "pylibfdt_tests.py", line 259, in testGetProperty
     self.fdt.get_property(root, 'wibble')
   File "../pylibfdt/libfdt.py", line 348, in get_property
     if self.string(pdata.nameoff) == name:
   File "../pylibfdt/libfdt.py", line 206, in string
     return fdt_string(self._fdt, fdt32_to_cpu(offset))
   File "../pylibfdt/libfdt.py", line 102, in fdt32_to_cpu
     return struct.unpack("=I", struct.pack(">I", val))[0]
error: integer out of range for 'I' format code

How I have found this issue:
I try to parse a big Xilinx-Device-Tree : 
http://www.wiki.xilinx.com/file/view/zcu102-arm-multi-arch.dts/582977135/zcu102-arm-multi-arch.dts
There at rp_gpio_pmu_intr: rp_gpio_pmu_intr@0 I have got the error two. 
I have tried to extract the problem and have included it in the 
test_tree1.dts.
The Device-Tree-Compiler says that with the patched test_tree1.dts is fine.

I have tried to fix the Problem, but I'm stuck. The problem is that the 
offset is negative.

If you like I can send a patch for a fdtdump python version.

Regards,
Benjamin Bimmmermann



 From 1530238b7070300899789e412bb38c7eec62b9c3 Mon Sep 17 00:00:00 2001
From: Benjamin Bimmermann <b.bimmermann-LWAfsSFWpa4@public.gmane.org>
Date: Mon, 5 Dec 2016 22:14:49 +0100
Subject: [PATCH] ADD | Add a part from the zcu102-arm-multi-arch.dts

---
  tests/test_tree1.dts | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/tests/test_tree1.dts b/tests/test_tree1.dts
index 67ecfd0..2887951 100644
--- a/tests/test_tree1.dts
+++ b/tests/test_tree1.dts
@@ -8,6 +8,12 @@
      prop-int = <0xdeadbeef>;
      prop-int64 = /bits/ 64 <0xdeadbeef01abcdef>;
      prop-str = "hello world";
+        #interrupt-cells = <0x1>;
+        remote-ports = <0x2 0x1>;
+        interrupt-controller;
+        num-gpios = <0x1>;
+        linux,phandle = <0x5b>;
+        phandle = <0x5b>;
      #address-cells = <1>;
      #size-cells = <0>;

-- 
2.5.0


[-- Attachment #2: 0001-ADD-Add-a-part-from-the-zcu102-arm-multi-arch.dts.patch --]
[-- Type: text/x-patch, Size: 790 bytes --]

From 1530238b7070300899789e412bb38c7eec62b9c3 Mon Sep 17 00:00:00 2001
From: Benjamin Bimmermann <b.bimmermann-LWAfsSFWpa4@public.gmane.org>
Date: Mon, 5 Dec 2016 22:14:49 +0100
Subject: [PATCH] ADD | Add a part from the zcu102-arm-multi-arch.dts

---
 tests/test_tree1.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/test_tree1.dts b/tests/test_tree1.dts
index 67ecfd0..2887951 100644
--- a/tests/test_tree1.dts
+++ b/tests/test_tree1.dts
@@ -8,6 +8,12 @@
 	prop-int = <0xdeadbeef>;
 	prop-int64 = /bits/ 64 <0xdeadbeef01abcdef>;
 	prop-str = "hello world";
+		#interrupt-cells = <0x1>;
+		remote-ports = <0x2 0x1>;
+		interrupt-controller;
+		num-gpios = <0x1>;
+		linux,phandle = <0x5b>;
+		phandle = <0x5b>;
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-- 
2.5.0

Re: coverage test failed

[Simon Glass]

Hi Benjamin,

On 5 December 2016 at 16:32, Benjamin Bimmermann
<benjamin.bimmermann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Simon,
>
> I have created a patch for the test_tree1.dts. If you run "coverage run
> pylibfdt_tests.py" with that patch you see the error:
>
> ERROR: testGetProperty (__main__.PyLibfdtTests)
> Check that we can read the details of a property
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "pylibfdt_tests.py", line 259, in testGetProperty
>     self.fdt.get_property(root, 'wibble')
>   File "../pylibfdt/libfdt.py", line 348, in get_property
>     if self.string(pdata.nameoff) == name:
>   File "../pylibfdt/libfdt.py", line 206, in string
>     return fdt_string(self._fdt, fdt32_to_cpu(offset))
>   File "../pylibfdt/libfdt.py", line 102, in fdt32_to_cpu
>     return struct.unpack("=I", struct.pack(">I", val))[0]
> error: integer out of range for 'I' format code
>
> How I have found this issue:
> I try to parse a big Xilinx-Device-Tree :
> http://www.wiki.xilinx.com/file/view/zcu102-arm-multi-arch.dts/582977135/zcu102-arm-multi-arch.dts
> There at rp_gpio_pmu_intr: rp_gpio_pmu_intr@0 I have got the error two. I
> have tried to extract the problem and have included it in the
> test_tree1.dts.
> The Device-Tree-Compiler says that with the patched test_tree1.dts is fine.
>
> I have tried to fix the Problem, but I'm stuck. The problem is that the
> offset is negative.

The string() function does a byteswap. I wonder if that is causing
problems? It should be done by the caller, as David pointed out in the
next version.

>
> If you like I can send a patch for a fdtdump python version.
>

Sounds good!

- Simon