From: Rob Herring <robh+dt@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Tero Kristo <t-kristo@ti.com>,
Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays
Date: Wed, 5 Sep 2018 16:13:23 -0500 [thread overview]
Message-ID: <CAL_JsqLKNnYD_hrpiV+34Mwf6xLfQQWZVJE7nuPYDL3ExDPemw@mail.gmail.com> (raw)
In-Reply-To: <71d48595-f40f-acce-2660-ce1630ffc398@gmail.com>
On Wed, Sep 5, 2018 at 3:36 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> +cc: devicetree-compiler@vger.kernel.org
>
> For context on the device-tree compiler list, this patch is for
> the Linux kernel.
>
> On 09/04/18 01:05, Tero Kristo wrote:
> > Add simple support for building DT overlays. This just compiles any
> > given .dtso file under the base arch/arm/boot/dts directory into
> > a .dtbo.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > ---
> > arch/arm/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index d1516f8..ab555a0 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -339,7 +339,7 @@ $(BOOT_TARGETS): vmlinux
> > $(INSTALL_TARGETS):
> > $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
> >
> > -%.dtb: | scripts
> > +%.dtb %.dtbo: | scripts
This will need to change with my rework of the DT build rules[1].
> > $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
> >
> > PHONY += dtbs dtbs_install
> >
>
> The idea of adding knowledge of .dtso and .dtbo files to the dtc
> compiler, but that idea and the related patches have fallen by
> the wayside.
>
> Current overlay sources and blobs are properly handled by dtc when
> they are .dts and .dtb files.
>
> If the dtc compiler is updated with knowledge of .dtso and .dtbo
> then these changes would be needed. At the moment the distinction
> of a .dtso and .dtbo is a naming convention that provides a clue
> about the intended use of the file. But dtc does not know these
> file name extensions, requiring a specific flag to tell dtc to
> treat them as .dts or .dtb files. I think the negative outweighs
> the positive for this patch.
I don't follow what you are proposing. We should decide on a convention though.
We shouldn't need .dtso because that is identified with the /plugin/
tag. Distinguishing overlay dtbs with .dtbo seems like a good idea
though.
Rob
[1] https://lkml.org/lkml/2018/8/21/770
next prev parent reply other threads:[~2018-09-05 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1535719666-13595-1-git-send-email-t-kristo@ti.com>
[not found] ` <1536048344-9995-1-git-send-email-t-kristo@ti.com>
[not found] ` <1536048344-9995-2-git-send-email-t-kristo@ti.com>
2018-09-05 20:36 ` [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays Frank Rowand
2018-09-05 21:13 ` Rob Herring [this message]
2018-09-06 21:00 ` Frank Rowand
[not found] ` <1536048344-9995-4-git-send-email-t-kristo@ti.com>
2018-09-05 20:36 ` [RESEND PATCHv2 3/4] arm64: " Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLKNnYD_hrpiV+34Mwf6xLfQQWZVJE7nuPYDL3ExDPemw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).