Re: [PATCH 1/2] Revert "libfdt: Add static lib to meson build"

["Marc-André Lureau" <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi Simon

On Mon, Jan 3, 2022 at 1:59 PM Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>
> Hi Marc-André,
>
> On Mon, 3 Jan 2022 at 00:39, <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> > You can build the static library by running meson configure
> > -Ddefault_library=both or static.
> >
> > This reverts commit 5216f3f1bbb70aef463b6cd78dbbb0f4c4c71606.
>
> What is the reason for the revert?

Did you miss the comment above?

There is no need to have a static_library() to build a static library.
library() handles both kinds, you just have to specify with the
-Ddefault_library option what you want.

> Regards,
> Simon
>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> >  libfdt/meson.build | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/libfdt/meson.build b/libfdt/meson.build
> > index 71f29b61e870..0307ffb8d7b9 100644
> > --- a/libfdt/meson.build
> > +++ b/libfdt/meson.build
> > @@ -24,11 +24,6 @@ libfdt = library(
> >    install: true,
> >  )
> >
> > -libfdt_a = static_library(
> > -  'fdt', sources,
> > -  install: true,
> > -)
> > -
> >  libfdt_inc = include_directories('.')
> >
> >  libfdt_dep = declare_dependency(
> > --
> > 2.34.1.8.g35151cf07204
> >
>