Re: [PATCH 0/3] Add a couple of string-related functions

[Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]

Hi Jon,

On 15 July 2015 at 07:29, Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org> wrote:
>
> So, like, Thierry Reding said:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > These three patches add a couple of string functions that have proven
> > useful in U-Boot's copy of libfdt, so they are likely to be useful for
> > other users as well.
> >
> > Patch 1 adds a function to count the number of strings in a property's
> > value. This also adds a new DTS sample along with a small test program
> > to validate the implemented functions.
> >
> > Patch 2 adds a function to retrieve the index of a given string in any
> > given property's value. This adds code to the test program introduced in
> > the previous patch to exercise the new functionality.
> >
> > Patch 3 adds a function to retrieve a string by index from a property's
> > value along with a shortcut for index 0. This extends the test program
> > introduced in patch 1 to validate the new functionality.
> >
> > Thierry
>
>
> Hi Thierry,
>
> While I am generally fine with this patch set, I have
> a large-scope question.  Is there a larger plan to
> consolidate or unify the U-Boot and DTC libfdts?

I maintain the fdt tree for U-Boot at present. About once a quarter I
check what has changed and do a bit of a sync. But there are things
that libfdt upstream has not accepted - e.g. the grep functionality
used by verified boot hashing stuff. I wish we could figure that out.
Perhaps a cut-down fdtgrep tool would meet with favour. We're using it
even more now since SPL (the minimal U-Boot loader) wants to run with
a subset of the full board FDT for SRAM space reasons.

I do ask people to send things upstream, and if rejected we then have
to work out what to do...there are recent U-Boot mailing list threads
on this.

Regards,
Simon