[PATCH] dtc: Remove -O dtbo support

[PATCH] dtc: Remove -O dtbo support

[Masahiro Yamada]

This partially reverts 163f0469bf2e ("dtc: Allow overlays to have
.dtbo extension").

I think accepting "dtbo" as --out-format is strange. This is not
shown by --help, at least.

*.dtb and *.dtbo should have the same format, "dtb".

Signed-off-by: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---

 dtc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dtc.c b/dtc.c
index 838c5df..3962d3f 100644
--- a/dtc.c
+++ b/dtc.c
@@ -359,8 +359,6 @@ int main(int argc, char *argv[])
 #endif
 	} else if (streq(outform, "dtb")) {
 		dt_to_blob(outf, dti, outversion);
-	} else if (streq(outform, "dtbo")) {
-		dt_to_blob(outf, dti, outversion);
 	} else if (streq(outform, "asm")) {
 		dt_to_asm(outf, dti, outversion);
 	} else if (streq(outform, "null")) {
-- 
2.27.0

Re: [PATCH] dtc: Remove -O dtbo support

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

On Thu, Mar 11, 2021 at 06:49:55PM +0900, Masahiro Yamada wrote:
> This partially reverts 163f0469bf2e ("dtc: Allow overlays to have
> .dtbo extension").
> 
> I think accepting "dtbo" as --out-format is strange. This is not
> shown by --help, at least.
> 
> *.dtb and *.dtbo should have the same format, "dtb".
> 
> Signed-off-by: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Oops, yes.  When reviewing 163f0469bf2e I missed the fact that it
accepted -O dtbo as well changing the default based on file extension.

Applied.

> ---
> 
>  dtc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/dtc.c b/dtc.c
> index 838c5df..3962d3f 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -359,8 +359,6 @@ int main(int argc, char *argv[])
>  #endif
>  	} else if (streq(outform, "dtb")) {
>  		dt_to_blob(outf, dti, outversion);
> -	} else if (streq(outform, "dtbo")) {
> -		dt_to_blob(outf, dti, outversion);
>  	} else if (streq(outform, "asm")) {
>  		dt_to_asm(outf, dti, outversion);
>  	} else if (streq(outform, "null")) {

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]