Re: [PATCH 2/5] checks: Add check_is_cell() for all phandle+arg properties

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2554 bytes --]

On Tue, May 25, 2021 at 08:03:32PM -0500, Rob Herring wrote:
> There's already a check for '#.*-cells' properties, so let's enable it for
> all the ones we already know about.
> 
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Good idea, applied.

> ---
>  checks.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/checks.c b/checks.c
> index eb91c8ea22fa..6a01a2468c42 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1466,7 +1466,8 @@ static void check_provider_cells_property(struct check *c,
>  }
>  #define WARNING_PROPERTY_PHANDLE_CELLS(nm, propname, cells_name, ...) \
>  	static struct provider nm##_provider = { (propname), (cells_name), __VA_ARGS__ }; \
> -	WARNING(nm##_property, check_provider_cells_property, &nm##_provider, &phandle_references);
> +	WARNING_IF_NOT_CELL(nm##_is_cell, cells_name); \
> +	WARNING(nm##_property, check_provider_cells_property, &nm##_provider, &nm##_is_cell, &phandle_references);
>  
>  WARNING_PROPERTY_PHANDLE_CELLS(clocks, "clocks", "#clock-cells");
>  WARNING_PROPERTY_PHANDLE_CELLS(cooling_device, "cooling-device", "#cooling-cells");
> @@ -1843,21 +1844,37 @@ static struct check *check_table[] = {
>  	&chosen_node_is_root, &chosen_node_bootargs, &chosen_node_stdout_path,
>  
>  	&clocks_property,
> +	&clocks_is_cell,
>  	&cooling_device_property,
> +	&cooling_device_is_cell,
>  	&dmas_property,
> +	&dmas_is_cell,
>  	&hwlocks_property,
> +	&hwlocks_is_cell,
>  	&interrupts_extended_property,
> +	&interrupts_extended_is_cell,
>  	&io_channels_property,
> +	&io_channels_is_cell,
>  	&iommus_property,
> +	&iommus_is_cell,
>  	&mboxes_property,
> +	&mboxes_is_cell,
>  	&msi_parent_property,
> +	&msi_parent_is_cell,
>  	&mux_controls_property,
> +	&mux_controls_is_cell,
>  	&phys_property,
> +	&phys_is_cell,
>  	&power_domains_property,
> +	&power_domains_is_cell,
>  	&pwms_property,
> +	&pwms_is_cell,
>  	&resets_property,
> +	&resets_is_cell,
>  	&sound_dai_property,
> +	&sound_dai_is_cell,
>  	&thermal_sensors_property,
> +	&thermal_sensors_is_cell,

Incidentally, if anyone can see a decent, portable way of avoiding the
ugly redundancy of listing all the tests in this array, I'd love to
hear it.

>  	&deprecated_gpio_property,
>  	&gpios_property,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]