From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja
Date: Tue, 8 Jun 2021 13:54:03 +1000 [thread overview]
Message-ID: <YL7p244p81KaDrHz@yekko> (raw)
In-Reply-To: <20201207130055.462734-6-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]
On Mon, Dec 07, 2020 at 05:00:55PM +0400, marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote:
> From: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> This avoids maintaining two build systems, and update the documentation.
>
> Makefile now wrap meson, so that make all/check/checkm/clean/install
> continue working as they used to.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Sorry I've neglected this so long. I finally got around to lookup up
a cheatsheet for how to use meson "natively" to understand this
better.
Couple of issues with this path though:
> ---
> Makefile | 380 ++-----------------------------------
> Makefile.convert-dtsv0 | 14 --
> Makefile.dtc | 23 ---
> Makefile.utils | 31 ---
> README | 24 ++-
> libfdt/Makefile.libfdt | 18 --
> pylibfdt/Makefile.pylibfdt | 30 ---
> tests/Makefile.tests | 100 ----------
First, it no longer applies clean due to some added tests. Can you
rebase please.
> +checkm:
> + WITH_VALGRIND=1 meson test -C $(BUILD_DIR) -v
Second, the valgrind stuff doesn't seem to work. I tried
"WITH_VALGRIND=1 meson test" and it completes much to fast to actually
be using valgrind. Also it doesn't give any error if valgrind isn't
installed.
It's also not ideal that the output from "meson test" is trivial with
all the content now in the meson log file. Assuming we can sort out
this first part, would you be willing to help convert the existing
testsuite / testrunner to be more "meson native" so we can improve
that?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-08 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 13:00 [PATCH 0/5] Follow-up on meson marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-1-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-12-07 13:00 ` [PATCH 1/5] meson: fix -Wall warning marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 2/5] meson: do not assume python is installed, skip tests marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 3/5] meson: increase default timeout for tests marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 4/5] travis: install meson marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-5-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-06-08 3:54 ` David Gibson
[not found] ` <CAMxuvax=yjONOpay9+CvYvV88MKFu84W8w0SpiDyg3GuQaHA0g@mail.gmail.com>
[not found] ` <CAMxuvax=yjONOpay9+CvYvV88MKFu84W8w0SpiDyg3GuQaHA0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-10 5:28 ` David Gibson
2020-12-07 13:00 ` [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-6-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-06-08 3:54 ` David Gibson [this message]
[not found] ` <CAMxuvaxcwrDiuxKizMjkXZFy6K3X0TSN-Z-=+SNXe53j1pMr1A@mail.gmail.com>
[not found] ` <CAMxuvaxcwrDiuxKizMjkXZFy6K3X0TSN-Z-=+SNXe53j1pMr1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-15 5:58 ` David Gibson
[not found] ` <CAMxuvaw2GoT-3CrTmBsiR==N2ZV3yJ--5MeN58DPypbJPrkfHQ@mail.gmail.com>
[not found] ` <CAMxuvaw2GoT-3CrTmBsiR==N2ZV3yJ--5MeN58DPypbJPrkfHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-19 9:31 ` David Gibson
2020-12-08 4:33 ` [PATCH 0/5] Follow-up on meson David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL7p244p81KaDrHz@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox