From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v4 1/4] README: Explain how to add a new API function
Date: Tue, 28 Dec 2021 20:14:49 +1100 [thread overview]
Message-ID: <YcrVic6pC4wM6oom@yekko> (raw)
In-Reply-To: <20211107224346.3181320-2-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Sun, Nov 07, 2021 at 03:43:43PM -0700, Simon Glass wrote:
> This is not obvious so add a little note about it.
>
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
This is a good change, regardless of anything else; merged.
> ---
>
> (no changes since v1)
>
> README | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/README b/README
> index d9bf850..bac1714 100644
> --- a/README
> +++ b/README
> @@ -71,6 +71,15 @@ More work remains to support all of libfdt, including access to numeric
> values.
>
>
> +Adding a new function to libfdt.h
> +---------------------------------
> +
> +The shared library uses libfdt/version.lds to list the exported functions, so
> +add your new function there. Check that your function works with pylibfdt. If
> +it cannot be supported, put the declaration in libfdt.h behind #ifndef SWIG so
> +that swig ignores it.
> +
> +
> Tests
> -----
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-28 9:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 22:43 [PATCH v4 0/4] Introduce fdtgrep for subsetting and hashing FDTs Simon Glass
[not found] ` <20211107224346.3181320-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2021-11-07 22:43 ` [PATCH v4 1/4] README: Explain how to add a new API function Simon Glass
[not found] ` <20211107224346.3181320-2-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2021-12-28 9:14 ` David Gibson [this message]
2021-11-07 22:43 ` [PATCH v4 2/4] libfdt: Add functions to find regions in an FDT Simon Glass
2021-11-07 22:43 ` [PATCH v4 3/4] Add fdtgrep to grep and hash FDTs Simon Glass
2021-11-07 22:43 ` [PATCH v4 4/4] Add tests for fdtgrep Simon Glass
2022-02-07 4:09 ` [PATCH v4 0/4] Introduce fdtgrep for subsetting and hashing FDTs David Gibson
2022-02-08 21:43 ` Simon Glass
[not found] ` <CAPnjgZ2HZCtfhF2BhUYk0a-UOVrMf0i_uQrbGPhWJoaq1ZtW1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-09 4:05 ` David Gibson
2022-02-09 16:04 ` Simon Glass
[not found] ` <CAPnjgZ2-tgy-L15S=p4dajpF+hSwX-McPSU3Fez2=cXOqXypZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-10 0:19 ` Rob Herring
[not found] ` <CAL_JsqJkG84jnn3OiC+aYOdqRvYcMWzfEg4r-74bbFsGC-4img-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-17 5:44 ` David Gibson
2022-02-17 20:37 ` Simon Glass
[not found] ` <CAPnjgZ2OjgXxQ0HxC_pBe+yZnmbJL-QYd+jDDQ5eacO=vkerNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-17 22:09 ` Rob Herring
[not found] ` <CAL_JsqLkOMELMjCNJ_xSt7hdVvHx5dMfrifzRWFuZQkGcsXwjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-17 22:44 ` Simon Glass
[not found] ` <CAPnjgZ1TM751YD-VOgk-+Kc--shAt4=1FaFdTyGGn5_27P0s0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-03-12 2:24 ` Simon Glass
[not found] ` <CAPnjgZ2HNTfdBz0jp0sqFhFN=sduTjkJR-5uVABvfZ_+O3Qj6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-03-14 16:22 ` Rob Herring
[not found] ` <CAL_Jsq+KzcUasbCOagXoLopDrNHrQQ5j0nE+CsgK_W1f8y9+0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-03-14 16:38 ` Simon Glass
[not found] ` <CAPnjgZ0cf=qVS=C-mno_0aB0gGXYu06LBoVp1n8QQT=mFfaj9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-03-14 17:11 ` Rob Herring
[not found] ` <CAL_JsqLMUrEoNXh9y4CpOgbcSsK1SRUPBoeDvd4+Vx9pkyXO2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-03-14 17:44 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcrVic6pC4wM6oom@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox