From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH] Fix some typos
Date: Fri, 14 Mar 2025 14:02:34 +1100 [thread overview]
Message-ID: <Z9OcSv28qi2yFe_j@zatzit> (raw)
In-Reply-To: <20250313191607.1556384-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 8227 bytes --]
On Thu, Mar 13, 2025 at 08:16:07PM +0100, Thomas Huth wrote:
> Discovered with the "codespell" utility.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Applied, thanks.
> ---
> README.license | 2 +-
> dtc.c | 2 +-
> dtc.h | 2 +-
> flattree.c | 2 +-
> libfdt/libfdt_internal.h | 4 ++--
> pylibfdt/libfdt.i | 2 +-
> tests/comments.dts | 2 +-
> tests/nopulate.c | 2 +-
> tests/run_tests.sh | 2 +-
> tests/testutils.c | 6 +++---
> tests/utilfdt_test.c | 2 +-
> 11 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/README.license b/README.license
> index 102b004..a4edc2b 100644
> --- a/README.license
> +++ b/README.license
> @@ -28,7 +28,7 @@ tools. Allowing libfdt to be used under the terms of the BSD license
> makes that it easier for vendors or authors of such software to do so.
>
> This does mean that libfdt code could be "stolen" - say, included in a
> -proprietary fimware and extended without contributing those extensions
> +proprietary firmware and extended without contributing those extensions
> back to the libfdt mainline. While I hope that doesn't happen, I
> believe the goal of allowing libfdt to be widely used is more
> important than avoiding that. libfdt is quite small, and hardly
> diff --git a/dtc.c b/dtc.c
> index beda8d5..b3445b7 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -15,7 +15,7 @@ int quiet; /* Level of quietness */
> unsigned int reservenum;/* Number of memory reservation slots */
> int minsize; /* Minimum blob size */
> int padsize; /* Additional padding to blob */
> -int alignsize; /* Additional padding to blob accroding to the alignsize */
> +int alignsize; /* Additional padding to blob according to the alignsize */
> int phandle_format = PHANDLE_EPAPR; /* Use linux,phandle or phandle properties */
> int generate_symbols; /* enable symbols & fixup support */
> int generate_fixups; /* suppress generation of fixups on symbol support */
> diff --git a/dtc.h b/dtc.h
> index 4c4aaca..9acf071 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -38,7 +38,7 @@ extern int quiet; /* Level of quietness */
> extern unsigned int reservenum; /* Number of memory reservation slots */
> extern int minsize; /* Minimum blob size */
> extern int padsize; /* Additional padding to blob */
> -extern int alignsize; /* Additional padding to blob accroding to the alignsize */
> +extern int alignsize; /* Additional padding to blob according to the alignsize */
> extern int phandle_format; /* Use linux,phandle or phandle properties */
> extern int generate_symbols; /* generate symbols for nodes with labels */
> extern int generate_fixups; /* generate fixups */
> diff --git a/flattree.c b/flattree.c
> index 1bcd808..30e6de2 100644
> --- a/flattree.c
> +++ b/flattree.c
> @@ -503,7 +503,7 @@ void dt_to_asm(FILE *f, struct dt_info *dti, int version)
> * Reserve map entries.
> * Align the reserve map to a doubleword boundary.
> * Each entry is an (address, size) pair of u64 values.
> - * Always supply a zero-sized temination entry.
> + * Always supply a zero-sized termination entry.
> */
> asm_emit_align(f, 8);
> emit_label(f, symprefix, "reserve_map");
> diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
> index 1fd35f3..773bba8 100644
> --- a/libfdt/libfdt_internal.h
> +++ b/libfdt/libfdt_internal.h
> @@ -56,8 +56,8 @@ static inline struct fdt_reserve_entry *fdt_mem_rsv_w_(void *fdt, int n)
> }
>
> /*
> - * Internal helpers to access tructural elements of the device tree
> - * blob (rather than for exaple reading integers from within property
> + * Internal helpers to access structural elements of the device tree
> + * blob (rather than for example reading integers from within property
> * values). We assume that we are either given a naturally aligned
> * address for the platform or if we are not, we are on a platform
> * where unaligned memory reads will be handled in a graceful manner.
> diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i
> index bb9985c..1f9c047 100644
> --- a/pylibfdt/libfdt.i
> +++ b/pylibfdt/libfdt.i
> @@ -162,7 +162,7 @@ class FdtRo(object):
> quiet: Errors to ignore (empty to raise on all errors)
>
> Returns:
> - Typle:
> + Tuple:
> Offset of the next node, if any, else a -ve error
> Depth of the returned node, if any, else undefined
>
> diff --git a/tests/comments.dts b/tests/comments.dts
> index 0b04b6b..d315d7f 100644
> --- a/tests/comments.dts
> +++ b/tests/comments.dts
> @@ -25,7 +25,7 @@
> prop7;
> /* yet
> * another
> - * multline
> + * multiline
> * comment
> */
> prop8;
> diff --git a/tests/nopulate.c b/tests/nopulate.c
> index e06a0b3..06f8369 100644
> --- a/tests/nopulate.c
> +++ b/tests/nopulate.c
> @@ -65,7 +65,7 @@ int main(int argc, char *argv[])
>
> verbose_printf("Nopulated structure block has new size %d\n", newsize);
>
> - /* Replace old strcutre block with the new */
> + /* Replace old structure block with the new */
>
> fdt2 = xmalloc(fdt_totalsize(fdt) + newsize);
>
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index f0b51c0..fecfe7c 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -805,7 +805,7 @@ dtc_tests () {
> run_dtc_test -I dtb -O dts -o stdin_odts_test_tree1.dtb.test.dts - < test_tree1.dtb
> run_wrap_test cmp stdin_odts_test_tree1.dtb.test.dts odts_test_tree1.dtb.test.dts
>
> - # Check integer expresisons
> + # Check integer expressions
> run_test integer-expressions -g integer-expressions.test.dts
> run_dtc_test -I dts -O dtb -o integer-expressions.test.dtb integer-expressions.test.dts
> run_test integer-expressions integer-expressions.test.dtb
> diff --git a/tests/testutils.c b/tests/testutils.c
> index 4c85111..54da2e4 100644
> --- a/tests/testutils.c
> +++ b/tests/testutils.c
> @@ -131,7 +131,7 @@ void check_property(void *fdt, int nodeoffset, const char *name,
> " differs from stored length (%d != %d)",
> name, retlen, proplen);
> if (proplen != len)
> - FAIL("Size mismatch on property \"%s\": %d insead of %d",
> + FAIL("Size mismatch on property \"%s\": %d instead of %d",
> name, proplen, len);
> if (len && memcmp(val, prop->data, len) != 0)
> FAIL("Data mismatch on property \"%s\"", name);
> @@ -148,7 +148,7 @@ const void *check_getprop(void *fdt, int nodeoffset, const char *name,
> FAIL("fdt_getprop(\"%s\"): %s", name, fdt_strerror(proplen));
>
> if (proplen != len)
> - FAIL("Size mismatch on property \"%s\": %d insead of %d",
> + FAIL("Size mismatch on property \"%s\": %d instead of %d",
> name, proplen, len);
> if (len && memcmp(val, propval, len) != 0)
> FAIL("Data mismatch on property \"%s\"", name);
> @@ -172,7 +172,7 @@ const void *check_get_prop_offset(void *fdt, int poffset, const char *exp_name,
> return NULL;
>
> if (proplen != exp_len)
> - FAIL("Size mismatch on property \"%s\": %d insead of %d",
> + FAIL("Size mismatch on property \"%s\": %d instead of %d",
> name, proplen, exp_len);
> if (exp_len && memcmp(exp_val, propval, exp_len))
> FAIL("Data mismatch on property \"%s\"", name);
> diff --git a/tests/utilfdt_test.c b/tests/utilfdt_test.c
> index f62341c..992807d 100644
> --- a/tests/utilfdt_test.c
> +++ b/tests/utilfdt_test.c
> @@ -46,7 +46,7 @@ static void checkfail(const char *fmt)
> * Add the given modifier to each of the valid sizes, and check that we get
> * correct values.
> *
> - * \param modifier Modifer string to use as a prefix
> + * \param modifier Modifier string to use as a prefix
> * \param expected_size The size (in bytes) that we expect (ignored for
> * strings)
> */
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-03-14 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 19:16 [PATCH] Fix some typos Thomas Huth
2025-03-14 3:02 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9OcSv28qi2yFe_j@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox