[PATCH] Makefile: do not hardcode the `install` program path

[PATCH] Makefile: do not hardcode the `install` program path

[Samuel Tardieu]

On systems that do not use the FHS, such as NixOS, the `install` program is not
located in `/usr/bin/` as its location is dynamic.

`dtc` can be easily installed on such systems by using the `install` program
available in the `$PATH` with:

    make PREFIX=… INSTALL=install

However, this becomes more difficult when `dtc` is being compiled as part of a
larger toolchain, as the toolchain build scripts will not spontaneously pass
such an argument on the command line. This happens for example when `dtc` is
build as a part of the RTEMS build system.

By not hardcoding a predefined path for `install`, as is done for other
executables, `dtc` will allow the one in the `$PATH` to be used.

Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 10a56d4..f1f0ab3 100644
--- a/Makefile
+++ b/Makefile
@@ -29,7 +29,7 @@ SWIG = swig
 PKG_CONFIG ?= pkg-config
 PYTHON ?= python3
 
-INSTALL = /usr/bin/install
+INSTALL = install
 INSTALL_PROGRAM = $(INSTALL)
 INSTALL_LIB = $(INSTALL)
 INSTALL_DATA = $(INSTALL) -m 644
-- 
2.43.0

Re: [PATCH] Makefile: do not hardcode the `install` program path

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

On Thu, Feb 08, 2024 at 08:14:05PM +0100, Samuel Tardieu wrote:
> On systems that do not use the FHS, such as NixOS, the `install` program is not
> located in `/usr/bin/` as its location is dynamic.
> 
> `dtc` can be easily installed on such systems by using the `install` program
> available in the `$PATH` with:
> 
>     make PREFIX=… INSTALL=install
> 
> However, this becomes more difficult when `dtc` is being compiled as part of a
> larger toolchain, as the toolchain build scripts will not spontaneously pass
> such an argument on the command line. This happens for example when `dtc` is
> build as a part of the RTEMS build system.
> 
> By not hardcoding a predefined path for `install`, as is done for other
> executables, `dtc` will allow the one in the `$PATH` to be used.
> 
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>

Applied, thanks.

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 10a56d4..f1f0ab3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -29,7 +29,7 @@ SWIG = swig
>  PKG_CONFIG ?= pkg-config
>  PYTHON ?= python3
>  
> -INSTALL = /usr/bin/install
> +INSTALL = install
>  INSTALL_PROGRAM = $(INSTALL)
>  INSTALL_LIB = $(INSTALL)
>  INSTALL_DATA = $(INSTALL) -m 644

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]