Re: [PATCH] libfdt: overlay: Fix phandle overwrite check for new subtrees

Rob Herring
2024-07-03T17:06:47Z

On Tue, Jul 2, 2024 at 7:44 AM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> Hello David,
>
> On Wed, Jun 26, 2024 at 09:55:52AM +0200, Uwe Kleine-König wrote:
> > If the overlay's target is only created in a previous fragment, it
> > doesn't exist in the unmodified base device tree. For the phandle
> > overwrite check this can be ignored because in this case the base tree
> > doesn't contain a phandle that could be overwritten.
> >
> > Adapt the corresponding check to not error out if that happens but just
> > continue with the next fragment.
> >
> > This is currently triggered by
> > arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dtso in the kernel
> > repository which creates /panel in its first fragment and modifies it in
> > its second.
> >
> > Reported-by: Rob Herring <robh@kernel.org>
> > Link: https://lore.kernel.org/all/CAL_JsqL9MPycDjqQfPNAuGfC6EMrdzUivr+fuOS7YgU3biGd4A@mail.gmail.com/
> > Fixes: 1fad065080e6 ("libfdt: overlay: ensure that existing phandles are not overwritten")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>
> I wonder about this patch's state. Does David wait for feedback by Rob
> as he reported the issue? Does Rob expect Geert to comment as
> salvator-panel-aa104xd12.dtso is in his maintainer area? Are the
> responsible people just busy; or is this fix already hidden in their
> backlog?

I think it's just waiting on David.

The patch looks good to me, but I haven't tested it nor am I that
familiar with this particular code.

Rob