Re: [PATCH] libfdt: overlay: Fix phandle overwrite check for new subtrees

Uwe Kleine-König
2024-07-02T13:44:43Z

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

Hello David,

On Wed, Jun 26, 2024 at 09:55:52AM +0200, Uwe Kleine-König wrote:
> If the overlay's target is only created in a previous fragment, it
> doesn't exist in the unmodified base device tree. For the phandle
> overwrite check this can be ignored because in this case the base tree
> doesn't contain a phandle that could be overwritten.
>
> Adapt the corresponding check to not error out if that happens but just
> continue with the next fragment.
>
> This is currently triggered by
> arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dtso in the kernel
> repository which creates /panel in its first fragment and modifies it in
> its second.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Link: https://lore.kernel.org/all/CAL_JsqL9MPycDjqQfPNAuGfC6EMrdzUivr+fuOS7YgU3biGd4A@mail.gmail.com/
> Fixes: 1fad065080e6 ("libfdt: overlay: ensure that existing phandles are not overwritten")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

I wonder about this patch's state. Does David wait for feedback by Rob
as he reported the issue? Does Rob expect Geert to comment as
salvator-panel-aa104xd12.dtso is in his maintainer area? Are the
responsible people just busy; or is this fix already hidden in their
backlog?

Otherwise I think the patch is fine to go in. It passes the test suite
and adds a new test that fails without the code change (but passes when
the patch is applied completely).

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]