From: David Gibson <david@gibson.dropbear.id.au>
To: Simon Glass <sjg@chromium.org>
Cc: Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
Gua Guo <gua.guo@intel.com>
Subject: Re: [PATCH 6/6] setup: Add dependencies for Windows
Date: Mon, 12 Aug 2024 12:01:03 +1000 [thread overview]
Message-ID: <Zrls36hgOi9jIIf1@zatzit.fritz.box> (raw)
In-Reply-To: <ZrlqiYL4p6K14S6e@zatzit.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
On Mon, Aug 12, 2024 at 11:51:05AM +1000, David Gibson wrote:
> On Sun, Aug 11, 2024 at 09:02:48AM -0600, Simon Glass wrote:
> > From: Gua Guo <gua.guo@intel.com>
> >
> > Windows apparently builds pylibfdt if swig is declared as a dependency
> > in the setup file. Otherwise it must be installed manually and Windows
> > does not sport a package manager, so this is hard for users.
> >
> > This change seems to have no ill effects on Linux, at least.
> >
> > So add a new setup_requires line.
> >
> > Signed-off-by: Gua Guo <gua.guo@intel.com>
> > Signed-off-by: Simon Glass <sjg@chromium.org>
>
> Applied.
Oops, spoke too soon. While this works locally for me, it breaks on
the github CI. See:
https://github.com/dgibson/dtc/actions/runs/10344711112
> We do have windows build in our github actions. It would be great if
> a test for building pylibfdt properly there were added.
This remains true, once the Linux breakage is fixed.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-08-12 2:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 15:02 [PATCH 1/6] Require Python 3 Simon Glass
2024-08-11 15:02 ` [PATCH 2/6] Tidy up some pylint warnings Simon Glass
2024-08-12 1:40 ` David Gibson
2024-08-11 15:02 ` [PATCH 3/6] setup: Move version and full_description into a function Simon Glass
2024-08-12 1:42 ` David Gibson
2024-08-11 15:02 ` [PATCH 4/6] setup: Collect top-level code together Simon Glass
2024-08-11 15:02 ` [PATCH 5/6] setup: Move setting of srcdir down to the bottom Simon Glass
2024-08-12 1:50 ` David Gibson
2024-08-11 15:02 ` [PATCH 6/6] setup: Add dependencies for Windows Simon Glass
2024-08-12 1:51 ` David Gibson
2024-08-12 2:01 ` David Gibson [this message]
2024-08-14 2:15 ` Simon Glass
2024-08-11 15:05 ` [PATCH 1/6] Require Python 3 Simon Glass
2024-08-12 1:39 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrls36hgOi9jIIf1@zatzit.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=gua.guo@intel.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).