Re: [PATCH v2 2/2] meson: port python bindings to build natively via meson and meson-python

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

On Mon, Apr 28, 2025 at 09:41:43PM -0400, Eli Schwartz wrote:
> We get full build parallelism and fewer confusing ancient distutils
> paths. The python wheels build fully standalone, including linking
> libfdt as a static library.
> 
> For convenience, when running pip install a meson option is passed that
> prevents building tools or installing headers/pkgconfig files.
> meson-python would otherwise include them in the wheel itself, in case
> they are needed, but this is essentially a bit useless so don't bother.
> 
> The old setuptools-based build is now redundant and goes away.
> 
> Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

LGTM, excepting one tiny typo

[snip]
> diff --git a/pyproject.toml b/pyproject.toml
> new file mode 100644
> index 0000000..8682026
> --- /dev/null
> +++ b/pyproject.toml
> @@ -0,0 +1,33 @@
> +[build-system]
> +build-backend = 'mesonpy'
> +requires = ['meson-python']
> +
> +[project]
> +name = 'libfdt'
> +authors = [
> +    {name = 'Simon Glass', email = 'sjg@chromium.org'},
> +]
> +classifiers = [
> +    'Programming Language :: Python :: 3',
> +    'License :: OSI Approved :: BSD License',
> +    'License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)',
> +    'Operating System :: OS Independent',
> +]
> +description = 'Pthon binding for libfdt'

"Pthon"

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]