From: David Gibson <david@gibson.dropbear.id.au>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH v3 1/2] livetree: Simplify append_to_property()
Date: Tue, 19 Aug 2025 09:25:35 +1000 [thread overview]
Message-ID: <aKO2b1OK3eE8-yVo@zatzit> (raw)
In-Reply-To: <f3nskwqmfkf5i47qbnt4bfh4bfl4c4mt6lygay5cfethpzddj7@6c5bmfnd7g67>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Mon, Aug 18, 2025 at 12:38:57PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Aug 18, 2025 at 12:35:45PM +0200, Uwe Kleine-König wrote:
> > The two if branches are quite similar. Build the property first (in case
> > it doesn't exist) and then the common parts can be done outside the if
> > block.
>
> Argh, I failed to add my s-o-b line here. Maybe b4 picks it up when I
> write:
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Heh, thanks for adding this after. I'll take it from here and paste
it in.
> here. It's fixed in my working copy know, so if there will be a v4, this
> isn't an issue any more.
>
> Best regards
> Uwe
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-08-18 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 10:35 [PATCH v3 0/2] livetree: Add only new data to fixup nodes instead of complete regeneration Uwe Kleine-König
2025-08-18 10:35 ` [PATCH v3 1/2] livetree: Simplify append_to_property() Uwe Kleine-König
2025-08-18 10:38 ` Uwe Kleine-König
2025-08-18 23:25 ` David Gibson [this message]
2025-08-19 5:35 ` Uwe Kleine-König
2025-08-19 6:17 ` David Gibson
2025-08-19 11:24 ` Uwe Kleine-König
2025-08-18 10:35 ` [PATCH v3 2/2] livetree: Add only new data to fixup nodes instead of complete regeneration Uwe Kleine-König
2025-08-20 11:38 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKO2b1OK3eE8-yVo@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).