From: David Gibson <david@gibson.dropbear.id.au>
To: yuanlinyu <yuanlinyu@honor.com>
Cc: "devicetree-compiler@vger.kernel.org"
<devicetree-compiler@vger.kernel.org>
Subject: Re: [PATCH] label: collect labels to __phandles__ node in interger format
Date: Fri, 3 Oct 2025 16:29:09 +1000 [thread overview]
Message-ID: <aN9tNVi25NOxyJoW@zatzit> (raw)
In-Reply-To: <f1dc6b4b445a4429aaf416b00926b162@honor.com>
[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]
On Mon, Sep 29, 2025 at 02:33:19AM +0000, yuanlinyu wrote:
> Hi David and other devicetree developer,
>
> Could you help review this change ?
Sorry for the lack of reply. I'm not going to apply this. There's
currently a big discussion underway on this list (amongst others)
about better ways of doing runtime device tree modifications. ("Re:
Device tree representation of (hotplug) connectors: discussion at
ELCE").
My main point in that thread is that we need to reconsider the design
of this end-to-end, and not add more hacks on top of the overlay
mechanism which was never really designed for this.
>
> thanks
> -----Original Message-----
> From: yuanlinyu <yuanlinyu@honor.com>
> Sent: Monday, September 1, 2025 8:23 PM
> To: David Gibson <david@gibson.dropbear.id.au>
> Cc: devicetree-compiler@vger.kernel.org; yuanlinyu <yuanlinyu@honor.com>
> Subject: [PATCH] label: collect labels to __phandles__ node in interger format
>
> Currently labels are collect to __symbols__ node in path string format,
> the libufdt have no support of it when do overlay.
>
> Add a new method which collect labels in __phandles__ node which each
> entry is an interger format, it will allow libufdt to keep labels when
> do (stack) overlay.
>
> The new method including below points,
> 1. add an option -P for dtc tool, it will create __phandles__ node and
> labels in interger foramt
> 2. add new function in fdt_overlay.c to support merge __phandles__ node
> 3. add overlay test which test -P option
> ---
> dtc.c | 18 +++-
> dtc.h | 4 +-
> libfdt/fdt_overlay.c | 250 ++++++++++++++++++++++++++++++++++++++-----
> livetree.c | 76 +++++++++++--
> tests/run_tests.sh | 84 +++++++++++++++
> 5 files changed, 392 insertions(+), 40 deletions(-)
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-10-03 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 12:22 [PATCH] label: collect labels to __phandles__ node in interger format yuan linyu
2025-09-29 2:33 ` yuanlinyu
2025-10-03 6:29 ` David Gibson [this message]
2026-03-06 2:38 ` yuanlinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN9tNVi25NOxyJoW@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=yuanlinyu@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox