Re: [PATCH] label: collect labels to __phandles__ node in interger format

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 3147 bytes --]

On Fri, Mar 06, 2026 at 02:38:56AM +0000, yuanlinyu wrote:
> > From: David Gibson <david@gibson.dropbear.id.au>
> > Sent: Friday, October 3, 2025 2:29 PM
> > To: yuanlinyu <yuanlinyu@honor.com>
> > Cc: devicetree-compiler@vger.kernel.org
> > Subject: Re: [PATCH] label: collect labels to __phandles__ node in interger
> > format
> > 
> > On Mon, Sep 29, 2025 at 02:33:19AM +0000, yuanlinyu wrote:
> > > Hi David and other devicetree developer,
> > >
> > > Could you help review this change ?
> > 
> > Sorry for the lack of reply.  I'm not going to apply this.  There's currently a big
> > discussion underway on this list (amongst others) about better ways of doing
> > runtime device tree modifications.  ("Re:
> > Device tree representation of (hotplug) connectors: discussion at ELCE").
> > 
> > My main point in that thread is that we need to reconsider the design of this
> > end-to-end, and not add more hacks on top of the overlay mechanism which was
> > never really designed for this.
> 
> Hi maintainer,
> Is it possible to reconsider to take this change ?

Not unless I'm given concrete reasons I should reconsider it.

> Or could you share the idea to improve it ?

I barely have time to give feedback to much better considered
proposals than this, so not really, no.  Look at that thread and
others on the lists and join the discussion there.


> 
> > 
> > >
> > > thanks
> > > -----Original Message-----
> > > From: yuanlinyu <yuanlinyu@honor.com>
> > > Sent: Monday, September 1, 2025 8:23 PM
> > > To: David Gibson <david@gibson.dropbear.id.au>
> > > Cc: devicetree-compiler@vger.kernel.org; yuanlinyu
> > > <yuanlinyu@honor.com>
> > > Subject: [PATCH] label: collect labels to __phandles__ node in
> > > interger format
> > >
> > > Currently labels are collect to __symbols__ node in path string
> > > format, the libufdt have no support of it when do overlay.
> > >
> > > Add a new method which collect labels in __phandles__ node which each
> > > entry is an interger format, it will allow libufdt to keep labels when
> > > do (stack) overlay.
> > >
> > > The new method including below points, 1. add an option -P for dtc
> > > tool, it will create __phandles__ node and labels in interger foramt
> > > 2. add new function in fdt_overlay.c to support merge __phandles__
> > > node 3. add overlay test which test -P option
> > > ---
> > >  dtc.c                |  18 +++-
> > >  dtc.h                |   4 +-
> > >  libfdt/fdt_overlay.c | 250 ++++++++++++++++++++++++++++++++++++++-----
> > >  livetree.c           |  76 +++++++++++--
> > >  tests/run_tests.sh   |  84 +++++++++++++++
> > >  5 files changed, 392 insertions(+), 40 deletions(-)
> > 
> > --
> > David Gibson (he or they)	| I'll have my music baroque, and my code
> > david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
> > 				| around.
> > http://www.ozlabs.org/~dgibson

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]