* Re: [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays [not found] ` <1536048344-9995-2-git-send-email-t-kristo@ti.com> @ 2018-09-05 20:36 ` Frank Rowand 2018-09-05 21:13 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Frank Rowand @ 2018-09-05 20:36 UTC (permalink / raw) To: Tero Kristo, catalin.marinas, will.deacon, linux, robh+dt Cc: mark.rutland, devicetree, tony, Devicetree Compiler, linux-arm-kernel +cc: devicetree-compiler@vger.kernel.org For context on the device-tree compiler list, this patch is for the Linux kernel. On 09/04/18 01:05, Tero Kristo wrote: > Add simple support for building DT overlays. This just compiles any > given .dtso file under the base arch/arm/boot/dts directory into > a .dtbo. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- > arch/arm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index d1516f8..ab555a0 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -339,7 +339,7 @@ $(BOOT_TARGETS): vmlinux > $(INSTALL_TARGETS): > $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@ > > -%.dtb: | scripts > +%.dtb %.dtbo: | scripts > $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ > > PHONY += dtbs dtbs_install > The idea of adding knowledge of .dtso and .dtbo files to the dtc compiler, but that idea and the related patches have fallen by the wayside. Current overlay sources and blobs are properly handled by dtc when they are .dts and .dtb files. If the dtc compiler is updated with knowledge of .dtso and .dtbo then these changes would be needed. At the moment the distinction of a .dtso and .dtbo is a naming convention that provides a clue about the intended use of the file. But dtc does not know these file name extensions, requiring a specific flag to tell dtc to treat them as .dts or .dtb files. I think the negative outweighs the positive for this patch. -Frank ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays 2018-09-05 20:36 ` [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays Frank Rowand @ 2018-09-05 21:13 ` Rob Herring 2018-09-06 21:00 ` Frank Rowand 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2018-09-05 21:13 UTC (permalink / raw) To: Frank Rowand Cc: Mark Rutland, devicetree, Tony Lindgren, Catalin Marinas, Will Deacon, Russell King, Tero Kristo, Devicetree Compiler, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On Wed, Sep 5, 2018 at 3:36 PM Frank Rowand <frowand.list@gmail.com> wrote: > > +cc: devicetree-compiler@vger.kernel.org > > For context on the device-tree compiler list, this patch is for > the Linux kernel. > > On 09/04/18 01:05, Tero Kristo wrote: > > Add simple support for building DT overlays. This just compiles any > > given .dtso file under the base arch/arm/boot/dts directory into > > a .dtbo. > > > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > > --- > > arch/arm/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > > index d1516f8..ab555a0 100644 > > --- a/arch/arm/Makefile > > +++ b/arch/arm/Makefile > > @@ -339,7 +339,7 @@ $(BOOT_TARGETS): vmlinux > > $(INSTALL_TARGETS): > > $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@ > > > > -%.dtb: | scripts > > +%.dtb %.dtbo: | scripts This will need to change with my rework of the DT build rules[1]. > > $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ > > > > PHONY += dtbs dtbs_install > > > > The idea of adding knowledge of .dtso and .dtbo files to the dtc > compiler, but that idea and the related patches have fallen by > the wayside. > > Current overlay sources and blobs are properly handled by dtc when > they are .dts and .dtb files. > > If the dtc compiler is updated with knowledge of .dtso and .dtbo > then these changes would be needed. At the moment the distinction > of a .dtso and .dtbo is a naming convention that provides a clue > about the intended use of the file. But dtc does not know these > file name extensions, requiring a specific flag to tell dtc to > treat them as .dts or .dtb files. I think the negative outweighs > the positive for this patch. I don't follow what you are proposing. We should decide on a convention though. We shouldn't need .dtso because that is identified with the /plugin/ tag. Distinguishing overlay dtbs with .dtbo seems like a good idea though. Rob [1] https://lkml.org/lkml/2018/8/21/770 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays 2018-09-05 21:13 ` Rob Herring @ 2018-09-06 21:00 ` Frank Rowand 0 siblings, 0 replies; 4+ messages in thread From: Frank Rowand @ 2018-09-06 21:00 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, devicetree, Tony Lindgren, Catalin Marinas, Will Deacon, Russell King, Tero Kristo, Devicetree Compiler, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On 09/05/18 14:13, Rob Herring wrote: > On Wed, Sep 5, 2018 at 3:36 PM Frank Rowand <frowand.list@gmail.com> wrote: >> >> +cc: devicetree-compiler@vger.kernel.org >> >> For context on the device-tree compiler list, this patch is for >> the Linux kernel. >> >> On 09/04/18 01:05, Tero Kristo wrote: >>> Add simple support for building DT overlays. This just compiles any >>> given .dtso file under the base arch/arm/boot/dts directory into >>> a .dtbo. >>> >>> Signed-off-by: Tero Kristo <t-kristo@ti.com> >>> --- >>> arch/arm/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/Makefile b/arch/arm/Makefile >>> index d1516f8..ab555a0 100644 >>> --- a/arch/arm/Makefile >>> +++ b/arch/arm/Makefile >>> @@ -339,7 +339,7 @@ $(BOOT_TARGETS): vmlinux >>> $(INSTALL_TARGETS): >>> $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@ >>> >>> -%.dtb: | scripts >>> +%.dtb %.dtbo: | scripts > > This will need to change with my rework of the DT build rules[1]. > >>> $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ >>> >>> PHONY += dtbs dtbs_install >>> >> >> The idea of adding knowledge of .dtso and .dtbo files to the dtc >> compiler, but that idea and the related patches have fallen by >> the wayside. >> >> Current overlay sources and blobs are properly handled by dtc when >> they are .dts and .dtb files. >> >> If the dtc compiler is updated with knowledge of .dtso and .dtbo >> then these changes would be needed. At the moment the distinction >> of a .dtso and .dtbo is a naming convention that provides a clue >> about the intended use of the file. But dtc does not know these >> file name extensions, requiring a specific flag to tell dtc to >> treat them as .dts or .dtb files. I think the negative outweighs >> the positive for this patch. > > I don't follow what you are proposing. We should decide on a convention though. > > We shouldn't need .dtso because that is identified with the /plugin/ > tag. Distinguishing overlay dtbs with .dtbo seems like a good idea > though. I noted technical reasons that using .dtbo has both good and bad aspects. I too at times just fall back to a "sounds good" or "sounds bad" type response (and will continue to do so in the future), but in this case please provide a somewhat stronger reasoning for using .dtbo since I stated that I feel the in technical balance the negatives outweigh the positives. If dtc adds knowledge of .dtbo my opinion of the balance will immediately reverse. > > Rob > > [1] https://lkml.org/lkml/2018/8/21/770 > ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1536048344-9995-4-git-send-email-t-kristo@ti.com>]
* Re: [RESEND PATCHv2 3/4] arm64: dts: add support for building DT overlays [not found] ` <1536048344-9995-4-git-send-email-t-kristo@ti.com> @ 2018-09-05 20:36 ` Frank Rowand 0 siblings, 0 replies; 4+ messages in thread From: Frank Rowand @ 2018-09-05 20:36 UTC (permalink / raw) To: Tero Kristo, catalin.marinas, will.deacon, linux, robh+dt Cc: mark.rutland, devicetree, tony, Devicetree Compiler, linux-arm-kernel On 09/04/18 01:05, Tero Kristo wrote: > Add simple support for building DT overlays. This just compiles any > given .dtso file under the base arch/arm64/boot/dts/*/ directory into > a .dtbo. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- > arch/arm64/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index 106039d..f04c814 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -127,7 +127,7 @@ Image.%: Image > zinstall install: > $(Q)$(MAKE) $(build)=$(boot) $@ > > -%.dtb: scripts > +%.dtb %.dtbo: scripts > $(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@ > > PHONY += dtbs dtbs_install > Same comments as for patch 1/4. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-06 21:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1535719666-13595-1-git-send-email-t-kristo@ti.com>
[not found] ` <1536048344-9995-1-git-send-email-t-kristo@ti.com>
[not found] ` <1536048344-9995-2-git-send-email-t-kristo@ti.com>
2018-09-05 20:36 ` [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays Frank Rowand
2018-09-05 21:13 ` Rob Herring
2018-09-06 21:00 ` Frank Rowand
[not found] ` <1536048344-9995-4-git-send-email-t-kristo@ti.com>
2018-09-05 20:36 ` [RESEND PATCHv2 3/4] arm64: " Frank Rowand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).