From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frank Rowand <frowand.list@gmail.com>
Subject: Re: [RFC PATCH 1/3] dtc: Add dtb build information option
Date: Wed, 22 Jan 2020 13:54:52 -0600
Message-ID: <c3732a75-83bc-890f-9a02-d3a61c626a6c@gmail.com>
References: <20200113181625.3130-1-alexandre.torgue@st.com>
 <20200113181625.3130-2-alexandre.torgue@st.com>
 <20200116005741.GB54439@umbus> <d2594b79-a45d-dcac-3642-90016a1408b8@st.com>
 <20200117090937.GU54439@umbus>
 <CAL_JsqKTsX9efYDMjGahFDxj0cEfzozeNrY1Nq1bECzgOZGqdQ@mail.gmail.com>
 <20200120181708.GN3697@linaro.org>
 <9d83a36c-78c5-3452-bb48-209d68c46038@st.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Return-path: <linux-kbuild-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=AXqcs9WJmqdUels2VMQQnGKt+9ND4M0NUtQ6v5MXWoY=;
        b=MVM4rvKHeS6Q/bNILmRzNPca+0GRjbYna1jX+lwZUDerB/tvIH03gBrxx0LO23f+De
         rzdqENMv6hdhyFi5bVlEuk8R0akqk+LOVymPn6rG5TrOrdoy53bgJGlCeUPf1PT1aFVZ
         WLrnmDnYssRJWM44AV9gyJxMV6c9KpHo5nph0az6vm382j1rjOi0NQrxb1joow4ujq9m
         awv6ITa+gRJ29ZUt3dKEbmMhRy5vJCi3fYWRCtL54JDGlY8QgK98pgfQReSI9W+Vy0gO
         x8Xyi4uGYcotezBusfXs5OG2QKBcQfN2dPJkunBbpcq6M8V43lMlLlaZYxbX05mcjDWx
         wnxw==
In-Reply-To: <9d83a36c-78c5-3452-bb48-209d68c46038@st.com>
Content-Language: en-US
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <devicetree-compiler.vger.kernel.org>
Content-Type: text/plain; charset="utf-8"
To: Alexandre Torgue <alexandre.torgue@st.com>, Steve McIntyre <steve.mcintyre@linaro.org>, Rob Herring <robh+dt@kernel.org>, David Gibson <david@gibson.dropbear.id.au>, ian@freebsd.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, Michal Marek <michal.lkml@markovi.net>, Simon Glass <sjg@chromium.org>, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Devicetree Compiler <devicetree-compiler@vger.kernel.org>

On 1/22/20 12:00 PM, Alexandre Torgue wrote:
> Hi
> 
> On 1/20/20 7:17 PM, Steve McIntyre wrote:
>> On Fri, Jan 17, 2020 at 08:43:23AM -0600, Rob Herring wrote:
>>> On Fri, Jan 17, 2020 at 6:26 AM David Gibson
>>> <david@gibson.dropbear.id.au> wrote:
>>
>> ...
>>
>>>> What might be better would be to have a dtc option which force appends
>>>> an extra .dts to the mail .dts compiled.  You can then put an overlay
>>>> template in that file, something like:
>>>>
>>>> &{/} {
>>>>          linux,build-info = /incbin/ "build-info.txt;
>>>> }
>>>
>>> I like this suggestion either as an include another dts file or an
>>> overlay. The latter could be useful as a way to maintain current dtb
>>> files while splitting the source files into base and overlay dts
>>> files.
>>
>> ACK, that sounds like it could be helpful.
>>
>>> But no, let's not prepend this with 'linux'. It's not a property
>>> specific for Linux to consume.
>>
>> Right. We might be seeing the data coming through from U-Boot (or any
>> other random bootloader) too.
>>
>> Cheers,
>>
> 
> Thanks for reviews. I gonna prepare a V2 with David proposition (to use overlay format) by keeping in mind not to modify existing dts(i) files.
> 
> Remaining questions are:
> 
> 1- "build-info" or "linux,build-info"? IMO, If information is
> "generic" then first one should be used.


I would prefer build-info.  The data may be generated by a non-linux
build environment, such as uboot.


> 2- Looking at Franck proposition[1] some years ago and objections on
> it, do you think that this one could accepted ?

I think that with the few small changes suggested in this thread, that
the old objections are not relevant to your version.


> 
> regards
> Alex
> 
> [1] https://lore.kernel.org/linux-arm-kernel/550A42AC.8060104@gmail.com/
> 
> 
> 
> 
>