From: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: "Jon Loeliger" <loeliger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
Subject: Re: [PATCH V3] Support 'r' format for printing raw bytes with fdtget
Date: Thu, 9 Dec 2021 07:06:52 +0100 [thread overview]
Message-ID: <c59e41fd-bdfc-c419-e68f-0f6086c9b61e@gmail.com> (raw)
In-Reply-To: <YbGZlK/vOFaXtb21@yekko>
On 09.12.2021 06:52, David Gibson wrote:
>> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
>> index d100d5a..11068e1 100755
>> --- a/tests/run_tests.sh
>> +++ b/tests/run_tests.sh
>> @@ -855,6 +855,8 @@ fdtget_tests () {
>> run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size
>> run_fdtget_test "61 62 63 0" -tbx $dtb /randomnode tricky1
>> run_fdtget_test "a b c d de ea ad be ef" -tbx $dtb /randomnode blob
>> + run_fdtget_test "MyBoardName\0MyBoardFamilyName\0" -tr $dtb / compatible
>> + run_fdtget_test "\x0a\x0b\x0c\x0d\xde\xea\xad\xbe\xef" -tr $dtb /randomnode blob
>
> I think using \ escapes in strings will be shell dependent behaviour.
> Have you tested this in shells other than bash?
It isn't back dependent but printf dependent. See fdtget-runtest.sh :
printf '%b\n' "$expect" > $EXPECT
It seems even busybox's printf supports %b:
# printf "%b" "\x0a\x0b\x0c\x0d\xde\xea\xad\xbe\xef" | hexdump -C
00000000 0a 0b 0c 0d de ea ad be ef |.........|
00000009
next prev parent reply other threads:[~2021-12-09 6:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 15:49 [PATCH] Support 'b' format for printing raw bytes with fdtget Rafał Miłecki
[not found] ` <20211206154953.17089-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-07 15:07 ` Simon Glass
2021-12-08 17:00 ` [PATCH V2] " Rafał Miłecki
[not found] ` <20211208170055.13811-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-09 2:22 ` David Gibson
2021-12-09 5:30 ` [PATCH V3] Support 'r' " Rafał Miłecki
[not found] ` <20211209053041.17984-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-09 5:52 ` David Gibson
2021-12-09 6:06 ` Rafał Miłecki [this message]
[not found] ` <c59e41fd-bdfc-c419-e68f-0f6086c9b61e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-09 6:17 ` Rafał Miłecki
2021-12-09 6:23 ` David Gibson
2021-12-09 6:14 ` [PATCH V4] " Rafał Miłecki
[not found] ` <20211209061420.29466-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-09 6:52 ` David Gibson
2021-12-09 7:09 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59e41fd-bdfc-c419-e68f-0f6086c9b61e@gmail.com \
--to=zajec5-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=loeliger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).