From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3] Support 'r' format for printing raw bytes with fdtget Date: Thu, 9 Dec 2021 07:06:52 +0100 Message-ID: References: <20211208170055.13811-1-zajec5@gmail.com> <20211209053041.17984-1-zajec5@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=5NzQQnGkIq/ijLQUWEOMhtQtIKgTPH65kMArAs2ns7E=; b=pw6BPygvSf3fgGkyK54T3TdMp3ULxvYTpFlq5iLb/1YkOeVDvrEJ0SKqQOy8HvUy9a U4IbfdOgSU7T1rSTA1oHich6GWW1iE1lr1pFP/3JNk7yD2322SthOZ11JknO8Ud4LnFd 2t5hC8letpVLcyF/gq9bbY86OCuXhWFzNUp5XneGbOKiRyVMCSdWJKjSIkD5nKcqJ5Yr h/qJQ5YH4oTTfSaq7OIly+dVh+ECm7iKi+hwJ8wjB7LNqUojtJEAhId+wurjLzgmFxR4 f+kduXy2IXugjMu57ce8/+R53ZZlIxHl0u6Z3zLdNZG/Hyv2LyBQQy2fsXZAcq/3DohI kCwA== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Gibson Cc: Jon Loeliger , devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= On 09.12.2021 06:52, David Gibson wrote: >> diff --git a/tests/run_tests.sh b/tests/run_tests.sh >> index d100d5a..11068e1 100755 >> --- a/tests/run_tests.sh >> +++ b/tests/run_tests.sh >> @@ -855,6 +855,8 @@ fdtget_tests () { >> run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size >> run_fdtget_test "61 62 63 0" -tbx $dtb /randomnode tricky1 >> run_fdtget_test "a b c d de ea ad be ef" -tbx $dtb /randomnode blob >> + run_fdtget_test "MyBoardName\0MyBoardFamilyName\0" -tr $dtb / compatible >> + run_fdtget_test "\x0a\x0b\x0c\x0d\xde\xea\xad\xbe\xef" -tr $dtb /randomnode blob > > I think using \ escapes in strings will be shell dependent behaviour. > Have you tested this in shells other than bash? It isn't back dependent but printf dependent. See fdtget-runtest.sh : printf '%b\n' "$expect" > $EXPECT It seems even busybox's printf supports %b: # printf "%b" "\x0a\x0b\x0c\x0d\xde\xea\xad\xbe\xef" | hexdump -C 00000000 0a 0b 0c 0d de ea ad be ef |.........| 00000009