From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [RESEND PATCHv2 1/4] ARM: dts: add support for building DT overlays Date: Thu, 6 Sep 2018 14:00:35 -0700 Message-ID: References: <1535719666-13595-1-git-send-email-t-kristo@ti.com> <1536048344-9995-1-git-send-email-t-kristo@ti.com> <1536048344-9995-2-git-send-email-t-kristo@ti.com> <71d48595-f40f-acce-2660-ce1630ffc398@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TsxXbgO0mEYAyMQmaK8mA6C4lx6dMnxfhC/SthSns24=; b=LvpnMdK4XCFGrF JeXsHQzywT1ObqXzxLNKkOtbOjnS4EpI2+hJ0+vxjkhscawErUP3gjAjRDiAfIoUQ4WLVv7sAfo5G WN+wPREKn/y8kKcB5WykZhp+mbj26zaqAZhP4Q/v4eqENNJD5ybov63XcyyNt8urIdn44tvJvKXkT yVe1yEMo27aNF2nnL76bydLmQaOjTxdvul9Ccd/0vT8Iq4S2NGdQ9Fn7GVZFIBoALQse9yUTmamqu 7wufBXID/HbHokMUwMPcxqJFxagUV1UwKcLdMLAtN7wxd8xdoSPnc7+mMhsFfAFAmuYcziy4ZbveT 0rsHzdG8VYGkmTevP2Ow==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K/AnyBd/aiXJjEKiV5Qk1CvbwJVAQ/M/exJWA1FHoRg=; b=RCBcXv8RbsaGUB+tuXoQZzND9A5nSGYiKlgQTkvn7ZdIJ1ZDYTRx9zdQWtJHM1HbK/ 1nvtxh/nkUcEtIazas5ZmrANsVbkOyHHK+DPb8A4zymrbUJfjpEKijYVCaAU5w4BTPTQ e49ngaiVHOyqpFK5GAa2FzxrR9+SxZcJtcpuPxQLpKgIcliAR9sxMdAzPUCgrm4Yl7a9 Hz+haMblrGHwXQrkL/nQv33GwYFkfjx3YhJEHVstjForREcNFN0rq5XX5W3owbInTy/1 mBVMh0QYzvDZiynsLmhnny2zlp1c74+AzL/yD7mY1nQwGihrokwLIst9XAPE+/CLE4Tz YE7g== In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Tony Lindgren , Catalin Marinas , Will Deacon , Russell King , Tero Kristo , Devicetree Compiler , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" On 09/05/18 14:13, Rob Herring wrote: > On Wed, Sep 5, 2018 at 3:36 PM Frank Rowand wrote: >> >> +cc: devicetree-compiler@vger.kernel.org >> >> For context on the device-tree compiler list, this patch is for >> the Linux kernel. >> >> On 09/04/18 01:05, Tero Kristo wrote: >>> Add simple support for building DT overlays. This just compiles any >>> given .dtso file under the base arch/arm/boot/dts directory into >>> a .dtbo. >>> >>> Signed-off-by: Tero Kristo >>> --- >>> arch/arm/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/Makefile b/arch/arm/Makefile >>> index d1516f8..ab555a0 100644 >>> --- a/arch/arm/Makefile >>> +++ b/arch/arm/Makefile >>> @@ -339,7 +339,7 @@ $(BOOT_TARGETS): vmlinux >>> $(INSTALL_TARGETS): >>> $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@ >>> >>> -%.dtb: | scripts >>> +%.dtb %.dtbo: | scripts > > This will need to change with my rework of the DT build rules[1]. > >>> $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ >>> >>> PHONY += dtbs dtbs_install >>> >> >> The idea of adding knowledge of .dtso and .dtbo files to the dtc >> compiler, but that idea and the related patches have fallen by >> the wayside. >> >> Current overlay sources and blobs are properly handled by dtc when >> they are .dts and .dtb files. >> >> If the dtc compiler is updated with knowledge of .dtso and .dtbo >> then these changes would be needed. At the moment the distinction >> of a .dtso and .dtbo is a naming convention that provides a clue >> about the intended use of the file. But dtc does not know these >> file name extensions, requiring a specific flag to tell dtc to >> treat them as .dts or .dtb files. I think the negative outweighs >> the positive for this patch. > > I don't follow what you are proposing. We should decide on a convention though. > > We shouldn't need .dtso because that is identified with the /plugin/ > tag. Distinguishing overlay dtbs with .dtbo seems like a good idea > though. I noted technical reasons that using .dtbo has both good and bad aspects. I too at times just fall back to a "sounds good" or "sounds bad" type response (and will continue to do so in the future), but in this case please provide a somewhat stronger reasoning for using .dtbo since I stated that I feel the in technical balance the negatives outweigh the positives. If dtc adds knowledge of .dtbo my opinion of the balance will immediately reverse. > > Rob > > [1] https://lkml.org/lkml/2018/8/21/770 >