[PATCH DT spec 0/3] Misc fixes and additions for phy-connection-type

[PATCH DT spec 0/3] Misc fixes and additions for phy-connection-type

[Florian Fainelli]

Hi Grant,

Here are some fixes in the phy-connection-type property area, thanks!

Florian Fainelli (3):
  Fix property value for the Gigabit MII type
  Fix property name, table and defined value for "phy-connection-type"
  Document additional "phy-connection-type" values

 source/device-bindings.rst | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

-- 
2.7.4

[PATCH DT spec 1/3] Fix property value for the Gigabit MII type

[Florian Fainelli]

The property description is correct but the property value should be
"gmii" instead of "rgmii"

Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 source/device-bindings.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/device-bindings.rst b/source/device-bindings.rst
index 60e5560..ec50c67 100644
--- a/source/device-bindings.rst
+++ b/source/device-bindings.rst
@@ -337,7 +337,7 @@ the network device class.
    ===================================== ============
    Media Independent Interface           ``mii``
    Reduced Media Independent Interface   ``rmii``
-   Gigabit Media Independent Interface   ``rgmii``
+   Gigabit Media Independent Interface   ``gmii``
    Reduced Gigabit Media Independent     ``rgmii``
    rgmii with internal delay             ``rgmii-id``
    rgmii with internal delay on TX only  ``rgmii-txid``
-- 
2.7.4

[PATCH DT spec 2/3] Fix property name, table and defined value for "phy-connection-type"

[Florian Fainelli]

Table 4.12 describes the "phy-connection-type" property and its valid
values, not "max-speed" (which is at 4.11).

Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 source/device-bindings.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/source/device-bindings.rst b/source/device-bindings.rst
index ec50c67..6bf79ff 100644
--- a/source/device-bindings.rst
+++ b/source/device-bindings.rst
@@ -315,10 +315,10 @@ the network device class.
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. tabularcolumns:: | l J |
-.. table:: ``max-speed`` Property
+.. table:: ``phy-connection-type`` Property
 
    =========== ==============================================================
-   Property    ``max-speed``
+   Property    ``phy-connection-type``
    =========== ==============================================================
    Value type  ``<string>``
    Description Specifies interface type between the Ethernet device and a
@@ -330,7 +330,7 @@ the network device class.
    =========== ==============================================================
 
 .. tabularcolumns:: | l J |
-.. table:: Defined values for the ``max-speed`` Property
+.. table:: Defined values for the ``phy-connection-type`` Property
 
    ===================================== ============
    Connection type                       Value
-- 
2.7.4

[PATCH DT spec 3/3] Document additional "phy-connection-type" values

[Florian Fainelli]

Add the following values to the "phy-connection-type" property:

* Serial Gigabit Media Independent Interface      ``sgmii``
* Reverse Media Independent Interface             ``rev-mii``
* 10 Gigabits Media Independent Interface         ``xgmii``
* Multimedia over Coaxial                         ``moca``
* Quad Serial Gigabit Media Independent Interface ``qsgmii``

Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 source/device-bindings.rst | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/source/device-bindings.rst b/source/device-bindings.rst
index 6bf79ff..bf197ee 100644
--- a/source/device-bindings.rst
+++ b/source/device-bindings.rst
@@ -332,20 +332,25 @@ the network device class.
 .. tabularcolumns:: | l J |
 .. table:: Defined values for the ``phy-connection-type`` Property
 
-   ===================================== ============
+   =============================================== ============
    Connection type                       Value
-   ===================================== ============
-   Media Independent Interface           ``mii``
-   Reduced Media Independent Interface   ``rmii``
-   Gigabit Media Independent Interface   ``gmii``
-   Reduced Gigabit Media Independent     ``rgmii``
-   rgmii with internal delay             ``rgmii-id``
-   rgmii with internal delay on TX only  ``rgmii-txid``
-   rgmii with internal delay on RX only  ``rgmii-rxid``
-   Ten Bit Interface                     ``tbi``
-   Reduced Ten Bit Interface             ``rtbi``
-   Serial Media Independent Interface    ``smii``
-   ===================================== ============
+   =============================================== ============
+   Media Independent Interface                     ``mii``
+   Reduced Media Independent Interface             ``rmii``
+   Gigabit Media Independent Interface             ``gmii``
+   Reduced Gigabit Media Independent               ``rgmii``
+   rgmii with internal delay                       ``rgmii-id``
+   rgmii with internal delay on TX only            ``rgmii-txid``
+   rgmii with internal delay on RX only            ``rgmii-rxid``
+   Ten Bit Interface                               ``tbi``
+   Reduced Ten Bit Interface                       ``rtbi``
+   Serial Media Independent Interface              ``smii``
+   Serial Gigabit Media Independent Interface      ``sgmii``
+   Reverse Media Independent Interface             ``rev-mii``
+   10 Gigabits Media Independent Interface         ``xgmii``
+   Multimedia over Coaxial                         ``moca``
+   Quad Serial Gigabit Media Independent Interface ``qsgmii``
+   =============================================== ============
 
 ``phy-handle`` Property
 ^^^^^^^^^^^^^^^^^^^^^^^
-- 
2.7.4

Re: [PATCH DT spec 3/3] Document additional "phy-connection-type" values

[Grant Likely]

On Fri, May 6, 2016 at 6:08 AM, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Add the following values to the "phy-connection-type" property:
>
> * Serial Gigabit Media Independent Interface      ``sgmii``
> * Reverse Media Independent Interface             ``rev-mii``
> * 10 Gigabits Media Independent Interface         ``xgmii``
> * Multimedia over Coaxial                         ``moca``
> * Quad Serial Gigabit Media Independent Interface ``qsgmii``
>
> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Merged, thanks. Made one minor correction below...

> ---
>  source/device-bindings.rst | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
>
> diff --git a/source/device-bindings.rst b/source/device-bindings.rst
> index 6bf79ff..bf197ee 100644
> --- a/source/device-bindings.rst
> +++ b/source/device-bindings.rst
> @@ -332,20 +332,25 @@ the network device class.
>  .. tabularcolumns:: | l J |
>  .. table:: Defined values for the ``phy-connection-type`` Property
>
> -   ===================================== ============
> +   =============================================== ============
>     Connection type                       Value
> -   ===================================== ============

The "Value" heading needed to be indented further also to get the
table to render correctly.

g.

> -   Media Independent Interface           ``mii``
> -   Reduced Media Independent Interface   ``rmii``
> -   Gigabit Media Independent Interface   ``gmii``
> -   Reduced Gigabit Media Independent     ``rgmii``
> -   rgmii with internal delay             ``rgmii-id``
> -   rgmii with internal delay on TX only  ``rgmii-txid``
> -   rgmii with internal delay on RX only  ``rgmii-rxid``
> -   Ten Bit Interface                     ``tbi``
> -   Reduced Ten Bit Interface             ``rtbi``
> -   Serial Media Independent Interface    ``smii``
> -   ===================================== ============
> +   =============================================== ============
> +   Media Independent Interface                     ``mii``
> +   Reduced Media Independent Interface             ``rmii``
> +   Gigabit Media Independent Interface             ``gmii``
> +   Reduced Gigabit Media Independent               ``rgmii``
> +   rgmii with internal delay                       ``rgmii-id``
> +   rgmii with internal delay on TX only            ``rgmii-txid``
> +   rgmii with internal delay on RX only            ``rgmii-rxid``
> +   Ten Bit Interface                               ``tbi``
> +   Reduced Ten Bit Interface                       ``rtbi``
> +   Serial Media Independent Interface              ``smii``
> +   Serial Gigabit Media Independent Interface      ``sgmii``
> +   Reverse Media Independent Interface             ``rev-mii``
> +   10 Gigabits Media Independent Interface         ``xgmii``
> +   Multimedia over Coaxial                         ``moca``
> +   Quad Serial Gigabit Media Independent Interface ``qsgmii``
> +   =============================================== ============
>
>  ``phy-handle`` Property
>  ^^^^^^^^^^^^^^^^^^^^^^^
> --
> 2.7.4
>

Re: [PATCH DT spec 0/3] Misc fixes and additions for phy-connection-type

[Grant Likely]

On Fri, May 6, 2016 at 6:08 AM, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Grant,
>
> Here are some fixes in the phy-connection-type property area, thanks!
>
> Florian Fainelli (3):
>   Fix property value for the Gigabit MII type
>   Fix property name, table and defined value for "phy-connection-type"
>   Document additional "phy-connection-type" values
>
>  source/device-bindings.rst | 37 +++++++++++++++++++++----------------
>  1 file changed, 21 insertions(+), 16 deletions(-)

Merged all three. Thanks.

g.

>
> --
> 2.7.4
>