devicetree-spec.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS
@ 2025-02-16  1:45 Krishna Chaitanya Chundru
  2025-02-16  1:45 ` [PATCH V3 1/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay Krishna Chaitanya Chundru
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krishna Chaitanya Chundru @ 2025-02-16  1:45 UTC (permalink / raw)
  To: andersson, robh, dmitry.baryshkov, manivannan.sadhasivam, krzk,
	helgaas
  Cc: linux-arm-msm, devicetree, lpieralisi, kw, conor+dt, linux-pci,
	linux-kernel, devicetree-spec, quic_vbadigan,
	Krishna Chaitanya Chundru

Some controllers and endpoints provide provision to program the entry
delays of L0s & L1 which will allow the link to enter L0s & L1 more
aggressively to save power.

Per PCIe r6.0, sec 4.2.5.1, during Link training, a PCIe component
captures the N_FTS value it receives.  Per 4.2.5.6, when
transitioning the Link from L0s to L0, it must transmit N_FTS Fast
Training Sequences to enable the receiver to obtain bit and Symbol
lock.

Components may have device-specific ways to configure N_FTS values
to advertise during Link training.  Define an n-fts array with an
entry for each supported data rate.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
changes in v3:-
- Update the description to specfify about entries of the array (rob)
changes in v2:-
- Split N_FTS & L1 and L0s entry delay in two patches (bjorn)
- Update the commit text, description (bjorn)

Krishna Chaitanya Chundru (2):
  schemas: pci: bridge: Document PCI L0s & L1 entry delay
  schemas: pci: bridge: Document PCIe N_FTS

 dtschema/schemas/pci/pci-bus-common.yaml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH V3 1/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay
  2025-02-16  1:45 [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Krishna Chaitanya Chundru
@ 2025-02-16  1:45 ` Krishna Chaitanya Chundru
  2025-02-16  1:45 ` [PATCH V3 2/2] schemas: pci: bridge: Document PCIe N_FTS Krishna Chaitanya Chundru
  2025-02-19 19:49 ` [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Krishna Chaitanya Chundru @ 2025-02-16  1:45 UTC (permalink / raw)
  To: andersson, robh, dmitry.baryshkov, manivannan.sadhasivam, krzk,
	helgaas
  Cc: linux-arm-msm, devicetree, lpieralisi, kw, conor+dt, linux-pci,
	linux-kernel, devicetree-spec, quic_vbadigan,
	Krishna Chaitanya Chundru

Some controllers and endpoints provide provision to program the entry
delays of L0s & L1 which will allow the link to enter L0s & L1 more
aggressively to save power.

These values needs to be programmed before link training.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
 dtschema/schemas/pci/pci-bus-common.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dtschema/schemas/pci/pci-bus-common.yaml b/dtschema/schemas/pci/pci-bus-common.yaml
index 94b648f..a9309af 100644
--- a/dtschema/schemas/pci/pci-bus-common.yaml
+++ b/dtschema/schemas/pci/pci-bus-common.yaml
@@ -150,6 +150,12 @@ properties:
     description: Disables ASPM L0s capability
     type: boolean
 
+  aspm-l0s-entry-delay-ns:
+    description: ASPM L0s entry delay
+
+  aspm-l1-entry-delay-ns:
+    description: ASPM L1 entry delay
+
   vpcie12v-supply:
     description: 12v regulator phandle for the slot
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH V3 2/2] schemas: pci: bridge: Document PCIe N_FTS
  2025-02-16  1:45 [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Krishna Chaitanya Chundru
  2025-02-16  1:45 ` [PATCH V3 1/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay Krishna Chaitanya Chundru
@ 2025-02-16  1:45 ` Krishna Chaitanya Chundru
  2025-02-19 19:49 ` [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Krishna Chaitanya Chundru @ 2025-02-16  1:45 UTC (permalink / raw)
  To: andersson, robh, dmitry.baryshkov, manivannan.sadhasivam, krzk,
	helgaas
  Cc: linux-arm-msm, devicetree, lpieralisi, kw, conor+dt, linux-pci,
	linux-kernel, devicetree-spec, quic_vbadigan,
	Krishna Chaitanya Chundru

Per PCIe r6.0, sec 4.2.5.1, during Link training, a PCIe component
captures the N_FTS value it receives.  Per 4.2.5.6, when
transitioning the Link from L0s to L0, it must transmit N_FTS Fast
Training Sequences to enable the receiver to obtain bit and Symbol
lock.

Components may have device-specific ways to configure N_FTS values
to advertise during Link training.  Define an n_fts array with an
entry for each supported data rate.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
 dtschema/schemas/pci/pci-bus-common.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/dtschema/schemas/pci/pci-bus-common.yaml b/dtschema/schemas/pci/pci-bus-common.yaml
index a9309af..ca97a00 100644
--- a/dtschema/schemas/pci/pci-bus-common.yaml
+++ b/dtschema/schemas/pci/pci-bus-common.yaml
@@ -128,6 +128,16 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum: [ 1, 2, 4, 8, 16, 32 ]
 
+  n-fts:
+    description:
+      The number of Fast Training Sequences (N_FTS) required by the
+      Receiver (this component) when transitioning the Link from L0s
+      to L0; advertised during initial Link training. Each entry in
+      the array specifies a PCIe data rate
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 1
+    maxItems: 5
+
   reset-gpios:
     description: GPIO controlled connection to PERST# signal
     maxItems: 1
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS
  2025-02-16  1:45 [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Krishna Chaitanya Chundru
  2025-02-16  1:45 ` [PATCH V3 1/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay Krishna Chaitanya Chundru
  2025-02-16  1:45 ` [PATCH V3 2/2] schemas: pci: bridge: Document PCIe N_FTS Krishna Chaitanya Chundru
@ 2025-02-19 19:49 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2025-02-19 19:49 UTC (permalink / raw)
  To: Krishna Chaitanya Chundru
  Cc: andersson, dmitry.baryshkov, manivannan.sadhasivam, krzk, helgaas,
	linux-arm-msm, devicetree, lpieralisi, kw, conor+dt, linux-pci,
	linux-kernel, devicetree-spec, quic_vbadigan

On Sun, Feb 16, 2025 at 07:15:08AM +0530, Krishna Chaitanya Chundru wrote:
> Some controllers and endpoints provide provision to program the entry
> delays of L0s & L1 which will allow the link to enter L0s & L1 more
> aggressively to save power.
> 
> Per PCIe r6.0, sec 4.2.5.1, during Link training, a PCIe component
> captures the N_FTS value it receives.  Per 4.2.5.6, when
> transitioning the Link from L0s to L0, it must transmit N_FTS Fast
> Training Sequences to enable the receiver to obtain bit and Symbol
> lock.
> 
> Components may have device-specific ways to configure N_FTS values
> to advertise during Link training.  Define an n-fts array with an
> entry for each supported data rate.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> ---
> changes in v3:-
> - Update the description to specfify about entries of the array (rob)
> changes in v2:-
> - Split N_FTS & L1 and L0s entry delay in two patches (bjorn)
> - Update the commit text, description (bjorn)
> 
> Krishna Chaitanya Chundru (2):
>   schemas: pci: bridge: Document PCI L0s & L1 entry delay
>   schemas: pci: bridge: Document PCIe N_FTS
> 
>  dtschema/schemas/pci/pci-bus-common.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-19 19:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-16  1:45 [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Krishna Chaitanya Chundru
2025-02-16  1:45 ` [PATCH V3 1/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay Krishna Chaitanya Chundru
2025-02-16  1:45 ` [PATCH V3 2/2] schemas: pci: bridge: Document PCIe N_FTS Krishna Chaitanya Chundru
2025-02-19 19:49 ` [PATCH V3 0/2] schemas: pci: bridge: Document PCI L0s & L1 entry delay and N_FTS Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).