From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] Describe interrupts-extended property Date: Tue, 3 Jan 2017 14:29:31 -0800 Message-ID: <9a6be2c8-f7bd-f904-51a3-fa5093f0dd87@gmail.com> References: <20170103192423.5838-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=TZRBDpVhWHi8CQ4JvhcnAEvuresh1u+MlQfPdEl6x90=; b=YJ17ddb9waB36bv0O4eajdCk31joda4krAP+DzYEk0SxEVzsVro9mlHpx/dk+mxqcm ANejUFLjjJ5bDFoZ1sS3dorb//IiF1Kza/FJ8/046DCTqZgehjAOspgn4wNqiPLcFQBk zd561fkxbBQM8YHJncy+tLf5fzZyySn6QyS1v1VVr7zK68yCuGDJVkP4EA7VVlOO1/eq 4+AJKEcSJQcZc6XXwNIzYKRB8Ps2ylMjcuJqVv6zhTZK8ED1PApgj1iU2XTtySP0O6Do m1btR4n/yKS0EF0CGJ/+PByXsEVlTdLx17YTFbOnLOPqc336DTXVVn/R5d0kYO3BxeRz tb1g== In-Reply-To: Sender: devicetree-spec-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Rob Herring Cc: "devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely On 01/03/2017 02:24 PM, Rob Herring wrote: > Correcting Grant's email. > > On Tue, Jan 3, 2017 at 1:24 PM, Florian Fainelli wrote: >> The interrupts-extended property is a common property used when >> interrupt generating devices having interrupt lines in several interrupt >> controllers with possibly distinct interrupt specifiers. >> >> Signed-off-by: Florian Fainelli > > I assume this is mostly copied from the kernel documentation. This > needs Grant's ack as the kernel documentation license is ambiguous > (default GPL) and the spec is Apache. Sort of, I did look at the changes submitted to the documentation, but this was kind of rewritten from scratch, nonetheless, having some clarification on the documentation would indeed be a good thing. > >> --- >> source/devicetree-basics.rst | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/source/devicetree-basics.rst b/source/devicetree-basics.rst >> index be80af3d825b..1bda0fa54e7a 100644 >> --- a/source/devicetree-basics.rst >> +++ b/source/devicetree-basics.rst >> @@ -955,6 +955,40 @@ Description: >> to the interrupt parent. If this property is missing from a device, its >> interrupt parent is assumed to be its devicetree parent. >> >> +interrupts-extended >> +^^^^^^^^^^^^^^^^^^^ >> + >> +Property: ``interrupts-extended`` >> + >> +Value type: `` `` >> + >> +Description: >> + >> + The *interrupts-extended* property of a device node defines the interrupt or >> + the interrupts that are generated by the device. In case where an interrupt > > In the case... > >> + generating devices has several interrupt lines, some of them having distinct > > s/devices/device/ Whoops, thanks, anything else that needs fixing in the wording used below? > >> + interrupt parents, the *interrupts-extended* property should be used to >> + fully describe the interrupts of this device, relative to the interrupt >> + controller(s), which is encoded by the phandle part of the property. The non >> + phandle part of the property encodes the interrupt specifiers and obeys to >> + the *interrupts* property description. >> + >> + If both *interrupts-extended* and *interrupts* properties are present, the >> + *interrupts-extended* properties takes precedence, and the *interrupts* >> + property may be provided to a client program for compatibility purposes. >> + >> +Example: >> + >> + A device with several interrupt lines in distinct interrupt controllers, >> + having different interrupt specifiers is illustrated below. In this example >> + ``pic`` is an interrupt controller with an *#interrupt-cells* specifier >> + of 2, while ``gic`` is an interrupt controller with an *#interrupts-cells* >> + specifier of 1. >> + >> + >> + ``interrupts-extended = <&pic 0xA 8>, <&gic 0xda>;`` >> + >> + >> Properties for Interrupt Controllers >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> -- >> 2.9.3 >> -- Florian