devicetree-spec.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: reserved-memory: Add restricted-dma-pool constraints
@ 2022-02-17 17:47 Robin Murphy
       [not found] ` <a4f3d4e2feef008d1236ebc3f5f0c46360f20c60.1645119806.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Robin Murphy @ 2022-02-17 17:47 UTC (permalink / raw)
  To: devicetree-spec-u79uwXL29TY76Z2rM5mHXA
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, maxime-R63rPqgGiG5yDzI6CaY1VQ,
	devicetree-u79uwXL29TY76Z2rM5mHXA

The "restricted-dma-pool" definition prohibits combination with either
of the "no-map" and "reusable" properties, but this is only stated in
the description text. Add those constraints to the schema so we can
properly validate them.

Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
---

v2: Simplify with "properties:...:false" vs. "not:required:..."

 .../bindings/reserved-memory/shared-dma-pool.yaml      | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml b/Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml
index a4bf757d6881..618105f079be 100644
--- a/Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml
+++ b/Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml
@@ -56,6 +56,16 @@ properties:
       If this property is present, then Linux will use the region for
       the default pool of the consistent DMA allocator.
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: restricted-dma-pool
+then:
+  properties:
+    no-map: false
+    reusable: false
+
 unevaluatedProperties: false
 
 examples:
-- 
2.28.0.dirty


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: reserved-memory: Add restricted-dma-pool constraints
       [not found] ` <a4f3d4e2feef008d1236ebc3f5f0c46360f20c60.1645119806.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
@ 2022-02-17 22:40   ` Florian Fainelli
  2022-02-24 22:32   ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-02-17 22:40 UTC (permalink / raw)
  To: Robin Murphy, devicetree-spec-u79uwXL29TY76Z2rM5mHXA
  Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, maxime-R63rPqgGiG5yDzI6CaY1VQ,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On 2/17/22 9:47 AM, Robin Murphy wrote:
> The "restricted-dma-pool" definition prohibits combination with either
> of the "no-map" and "reusable" properties, but this is only stated in
> the description text. Add those constraints to the schema so we can
> properly validate them.
> 
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>

Acked-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

FWIW
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: reserved-memory: Add restricted-dma-pool constraints
       [not found] ` <a4f3d4e2feef008d1236ebc3f5f0c46360f20c60.1645119806.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
  2022-02-17 22:40   ` Florian Fainelli
@ 2022-02-24 22:32   ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-02-24 22:32 UTC (permalink / raw)
  To: Robin Murphy
  Cc: devicetree-spec-u79uwXL29TY76Z2rM5mHXA,
	maxime-R63rPqgGiG5yDzI6CaY1VQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thu, 17 Feb 2022 17:47:14 +0000, Robin Murphy wrote:
> The "restricted-dma-pool" definition prohibits combination with either
> of the "no-map" and "reusable" properties, but this is only stated in
> the description text. Add those constraints to the schema so we can
> properly validate them.
> 
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
> 
> v2: Simplify with "properties:...:false" vs. "not:required:..."
> 
>  .../bindings/reserved-memory/shared-dma-pool.yaml      | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-24 22:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-17 17:47 [PATCH v2] dt-bindings: reserved-memory: Add restricted-dma-pool constraints Robin Murphy
     [not found] ` <a4f3d4e2feef008d1236ebc3f5f0c46360f20c60.1645119806.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2022-02-17 22:40   ` Florian Fainelli
2022-02-24 22:32   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).