From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Subject: Re: [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property Date: Thu, 16 Feb 2023 09:54:02 -0600 Message-ID: References: <20230203-dt-bindings-network-class-v2-0-499686795073@jannau.net> <20230203-dt-bindings-network-class-v2-4-499686795073@jannau.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676562845; bh=zpw4rUtbOctUQatpRCHmdOEHG4xfpTTWwocYPyMJoQs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Yo3T9rTzjPHT5JNP0yXY3jvF6d8pbQURi+Fzdtt6JbCxr7HdvE4gz9/jsPxrLjDYS qq2zaZRin40p9UQtlwPtezXCNJ8noVIqLtNS8PsvjNkwZqWBfxMnZLuaYhePyhCJpP cyfpHD2jqVW3ftNVpCSfmlsdPVez/RJkghqYgz867v7CoYog1xZSJ81tPWQnLrr3Nn IqjmuPjtz9P2KflZL45O8UwqlWoQAcgszzfaOhpsv0YPaWP+EhFJ9UF2a6OjI/mpqk NN+NUwngX/uErWDCoQbUlokIoAT9rpseEvHnI/yc+smKP3w0XVeiWURdgU2VxJXG1+ EoOmjcn84mMuA== Content-Language: en-US In-Reply-To: <20230203-dt-bindings-network-class-v2-4-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Janne Grunau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Mailing List , Kalle Valo , van Spriel , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= , Ley Foon Tan , Chee Nouk Phoon Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 2/12/23 06:16, Janne Grunau wrote: > The given value of 1518 seems to refer to the layer 2 ethernet frame > size without 802.1Q tag. Actual use of the "max-frame-size" including in > the consumer of the "altr,tse-1.0" compatible is the MTU. > > Fixes: 95acd4c7b69c ("nios2: Device tree support") > Fixes: 61c610ec61bb ("nios2: Add Max10 device tree") > Signed-off-by: Janne Grunau > --- > arch/nios2/boot/dts/10m50_devboard.dts | 2 +- > arch/nios2/boot/dts/3c120_devboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/nios2/boot/dts/10m50_devboard.dts b/arch/nios2/boot/dts/10m50_devboard.dts > index 56339bef3247..0e7e5b0dd685 100644 > --- a/arch/nios2/boot/dts/10m50_devboard.dts > +++ b/arch/nios2/boot/dts/10m50_devboard.dts > @@ -97,7 +97,7 @@ rgmii_0_eth_tse_0: ethernet@400 { > rx-fifo-depth = <8192>; > tx-fifo-depth = <8192>; > address-bits = <48>; > - max-frame-size = <1518>; > + max-frame-size = <1500>; > local-mac-address = [00 00 00 00 00 00]; > altr,has-supplementary-unicast; > altr,enable-sup-addr = <1>; > diff --git a/arch/nios2/boot/dts/3c120_devboard.dts b/arch/nios2/boot/dts/3c120_devboard.dts > index d10fb81686c7..3ee316906379 100644 > --- a/arch/nios2/boot/dts/3c120_devboard.dts > +++ b/arch/nios2/boot/dts/3c120_devboard.dts > @@ -106,7 +106,7 @@ tse_mac: ethernet@4000 { > interrupt-names = "rx_irq", "tx_irq"; > rx-fifo-depth = <8192>; > tx-fifo-depth = <8192>; > - max-frame-size = <1518>; > + max-frame-size = <1500>; > local-mac-address = [ 00 00 00 00 00 00 ]; > phy-mode = "rgmii-id"; > phy-handle = <&phy0>; > Applied! Thanks, Dinh