From: "Karl O. Pinc" <kop@meme.com>
To: Bhushan Jain <bpjain@cs.stonybrook.edu>
Cc: "dm-crypt@saout.de" <dm-crypt@saout.de>
Subject: Re: [dm-crypt] An observation
Date: Tue, 09 Jul 2013 21:10:02 -0500 [thread overview]
Message-ID: <1373422202.9438.18@slate> (raw)
In-Reply-To: <D68F6C91D760CA4E9DFBA5AC6FFD249E28970E64@mail1.cs.stonybrook.edu> (from bpjain@cs.stonybrook.edu on Tue Nov 27 11:25:59 2012)
On 11/27/2012 11:25:59 AM, Bhushan Jain wrote:
> Hello Developers,
>
> I am a student at Stony Brook University researching system security.
> I noticed that the only reason dmcrypt-get-device (from eject
> package)
> needs setuid privilege is to read the major:minor numbers (unless I
> have missed something).
> A lot of distributions (Ubuntu, Fedora, etc.) are trying to avoid use
> of the setuid bit because it can potentially introduce a privilege
> escalation attack vector.
> I think the same thing could be accomplished by exporting the
> major:minor device numbers through a proc file, and then eliminate
> the
> need for dmcrypt-get-device.
> I would be happy to send you a patch that does this, if there is
> interest. Any comments/thoughts?
Speaking from ignorance, isn't there something in /sys with this
information? If so a patch to read from that might be better.
I'm ignorant, but I've this feeling that /proc is frowned upon.
Regards,
Karl <kop@meme.com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
next prev parent reply other threads:[~2013-07-10 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 17:25 [dm-crypt] An observation Bhushan Jain
2012-11-27 17:49 ` Milan Broz
2012-11-27 18:29 ` Javier Juan Martínez Cabezón
2013-07-10 2:10 ` Karl O. Pinc [this message]
2013-07-10 3:15 ` Bhushan Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373422202.9438.18@slate \
--to=kop@meme.com \
--cc=bpjain@cs.stonybrook.edu \
--cc=dm-crypt@saout.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox