From: Richard <rz@linux-m68k.org>
To: Emily Williams <emilyw@MIT.EDU>
Cc: dm-crypt@saout.de
Subject: Re: [dm-crypt] Avoiding fsck.ext4 destruction of crypto_luks data
Date: Mon, 31 Dec 2012 13:40:36 +0100 [thread overview]
Message-ID: <20121231124035.GA4438@rz> (raw)
In-Reply-To: <CA+VYMuZT3wnwA4nJd=WjgugwpvoV8n+zKKYEE+H02HY1CB=sjQ@mail.gmail.com>
On Sun, Dec 30, 2012 at 11:59:56AM -0500, Emily Williams wrote:
> On Fri, Dec 28, 2012 at 10:04 AM, Arno Wagner <arno@wagner.name> wrote:
> > > I wonder how fsck checks for a superblock. I still assume, that chances
> > of
> > > having encrypted data in the right block on disk looking like a correct
> > > ext-superblock is next to zero.
> >
> > The ext2 superblock magic number seems to be 0xEF53. That is a bit
> > short but still only gives something like 1 in 65536 probability of
> > misdetection in encrypted data. I think we can rule that out
> > for the moment.
>
>
> That actually seems like a pretty big chance to me. esp. if a hard drive
> manufacturer happens to have shipped a hard drive model where each hard
> drive has this problem.
fsck will not blindly trust a random superblock signature. All values inside
the superblock are checked if they are plausible. It will scream loudly if
superblock is screwed. The chance it will accept a random sector as valid
superblock is very very close to zero.
Richard
---
Name and OpenPGP keys available from pgp key servers
next prev parent reply other threads:[~2012-12-31 12:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 6:12 [dm-crypt] Avoiding fsck.ext4 destruction of crypto_luks data Emily Williams
2012-12-27 9:35 ` ken
2012-12-27 9:52 ` Arno Wagner
2012-12-28 14:46 ` Sven Eschenberg
2012-12-28 15:04 ` Arno Wagner
2012-12-28 19:22 ` Milan Broz
2012-12-29 7:06 ` Arno Wagner
2012-12-29 9:05 ` Milan Broz
2012-12-29 11:52 ` Arno Wagner
2012-12-30 8:42 ` Sven Eschenberg
2012-12-30 9:39 ` Milan Broz
2012-12-30 10:53 ` Arno Wagner
2012-12-30 12:08 ` Sven Eschenberg
2012-12-30 12:25 ` Milan Broz
2012-12-30 13:19 ` Arno Wagner
2012-12-30 16:59 ` Emily Williams
2012-12-30 18:49 ` Matthias Schniedermeyer
2012-12-30 19:45 ` Arno Wagner
2012-12-31 6:37 ` Sven Eschenberg
2012-12-31 12:40 ` Richard [this message]
2012-12-27 20:29 ` Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121231124035.GA4438@rz \
--to=rz@linux-m68k.org \
--cc=dm-crypt@saout.de \
--cc=emilyw@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox