[dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Robert Nichols]

What is the rationale behind the chk_luks_keyslots tool not being included by default in cryptsetup packages? It gets tiresome, and a bit embarrassing, explaining to novices who are in trouble that they need to build this tool from source.

-- 
Bob Nichols     "NOSPAM" is really part of my email address.
                 Do NOT delete it.

Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Arno Wagner]

I think that is a decision by the distros. I am certainly 
willing to maintain it for the foreseeable future. It is 
not really much effort.

Regards,
Arno


On Sat, Mar 28, 2020 at 22:56:25 CET, Robert Nichols wrote:
> What is the rationale behind the chk_luks_keyslots tool not being included
> by default in cryptsetup packages?  It gets tiresome, and a bit
> embarrassing, explaining to novices who are in trouble that they need to
> build this tool from source.
> 
> -- 
> Bob Nichols     "NOSPAM" is really part of my email address.
>                 Do NOT delete it.
> 
> _______________________________________________
> dm-crypt mailing list
> dm-crypt@saout.de
> https://www.saout.de/mailman/listinfo/dm-crypt

-- 
Arno Wagner,     Dr. sc. techn., Dipl. Inform.,    Email: arno@wagner.name
GnuPG: ID: CB5D9718  FP: 12D6 C03B 1B30 33BB 13CF  B774 E35C 5FA1 CB5D 9718
----
A good decision is based on knowledge and not on numbers. -- Plato

If it's in the news, don't worry about it.  The very definition of 
"news" is "something that hardly ever happens." -- Bruce Schneier

Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Jordan Glover]

On Sunday, March 29, 2020 10:20 AM, Arno Wagner <arno@wagner.name> wrote:

> I think that is a decision by the distros. I am certainly
> willing to maintain it for the foreseeable future. It is
> not really much effort.
>
> Regards,
> Arno

The distros just do "make install" [1]. I think it's upstream who decides what this command does.

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/cryptsetup#n39

Jordan

Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Milan Broz]

On 29/03/2020 14:34, Jordan Glover wrote:
> On Sunday, March 29, 2020 10:20 AM, Arno Wagner <arno@wagner.name> wrote:
> 
>> I think that is a decision by the distros. I am certainly
>> willing to maintain it for the foreseeable future. It is
>> not really much effort.
> 
> The distros just do "make install" [1]. I think it's upstream who decides what this command does.
> 
> [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/cryptsetup#n39

My plan was to include this check in repair command instead of adding additional binary.
(The code could remain basically the same.)

With LUKS2 we can store other data in binary keyslot area (depends on type), so it need a little
bit more work but it should not be a big problem.

Please report an issue for it, that helps to not forget about it.

Thanks,
Milan

Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Arno Wagner]

On Sun, Mar 29, 2020 at 16:09:56 CEST, Milan Broz wrote:
> On 29/03/2020 14:34, Jordan Glover wrote:
> > On Sunday, March 29, 2020 10:20 AM, Arno Wagner <arno@wagner.name> wrote:
> > 
> >> I think that is a decision by the distros. I am certainly
> >> willing to maintain it for the foreseeable future. It is
> >> not really much effort.
> > 
> > The distros just do "make install" [1]. I think it's upstream who decides what this command does.
> > 
> > [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/cryptsetup#n39
> 
> My plan was to include this check in repair command instead of adding
> additional binary.  (The code could remain basically the same.)
> 
> With LUKS2 we can store other data in binary keyslot area (depends on
> type), so it need a little bit more work but it should not be a big
> problem.
> 
> Please report an issue for it, that helps to not forget about it.
> 
> Thanks,
> Milan

Perfecly fine by me, feel fre to re-use any of the code that 
is there as you see fit.

Regards,
Arno

-- 
Arno Wagner,     Dr. sc. techn., Dipl. Inform.,    Email: arno@wagner.name
GnuPG: ID: CB5D9718  FP: 12D6 C03B 1B30 33BB 13CF  B774 E35C 5FA1 CB5D 9718
----
A good decision is based on knowledge and not on numbers. -- Plato

If it's in the news, don't worry about it.  The very definition of 
"news" is "something that hardly ever happens." -- Bruce Schneier

Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?

[Robert Nichols]

On 3/29/20 9:09 AM, Milan Broz wrote:
> On 29/03/2020 14:34, Jordan Glover wrote:
>> On Sunday, March 29, 2020 10:20 AM, Arno Wagner <arno@wagner.name> wrote:
>>
>>> I think that is a decision by the distros. I am certainly
>>> willing to maintain it for the foreseeable future. It is
>>> not really much effort.
>>
>> The distros just do "make install" [1]. I think it's upstream who decides what this command does.
>>
>> [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/cryptsetup#n39
> 
> My plan was to include this check in repair command instead of adding additional binary.
> (The code could remain basically the same.)
> 
> With LUKS2 we can store other data in binary keyslot area (depends on type), so it need a little
> bit more work but it should not be a big problem.
> 
> Please report an issue for it, that helps to not forget about it.

Done. https://gitlab.com/cryptsetup/cryptsetup/-/issues/545

-- 
Bob Nichols     "NOSPAM" is really part of my email address.
                 Do NOT delete it.