From: Phil Sutter <phil@nwl.cc>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-crypt@saout.de
Subject: [dm-crypt] Re: [cryptsetup PATCH] Make BitLocker support optional
Date: Fri, 29 Oct 2021 23:31:17 +0200 [thread overview]
Message-ID: <20211029213117.GY1668@orbyte.nwl.cc> (raw)
In-Reply-To: <08f502bf-d41a-6b6a-36f7-60b4bddc1497@gmail.com>
Hi Milan,
On Thu, Oct 28, 2021 at 09:14:10AM +0200, Milan Broz wrote:
> Support for all formats is mandatory (the pain to support various kernel configuration is already enough),
> so sorry, but I will not accept this patch.
I can relate but in this case the default is enabled so unless someone
really cares nothing changes.
> Also you cannot disable commands on CLI this way, it breaks user interface.
> (Command can fail, but must not dissappear.)
Sounds doable, assuming the above is not a final NACK. ;)
> What issues this solves have here? Why you cannot link it?
On an embedded device with uClibc I need libiconv which is 1.4MB in
size. I was hoping to avoid having to ship this rather large library.
While it's awesome that cryptsetup now supports bitlk partitions, I
don't think it will see much use on embedded devices (e.g. a small file
server).
> We use only some specific functions so the solution can be just to implement this internally.
Converting passphrases to utf16 is mandatory for bitlk support, right?
In general, I'm not sure if all this is feasible - libcryptsetup is
already 1.9MB and maintaining a mini-iconv is error-prone and likely to
remain mostly untested.
Cheers, Phil
_______________________________________________
dm-crypt mailing list -- dm-crypt@saout.de
To unsubscribe send an email to dm-crypt-leave@saout.de
next prev parent reply other threads:[~2021-10-29 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 23:29 [dm-crypt] [cryptsetup PATCH] Make BitLocker support optional Phil Sutter
2021-10-28 7:14 ` [dm-crypt] " Milan Broz
2021-10-29 21:31 ` Phil Sutter [this message]
2021-10-30 10:06 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029213117.GY1668@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=dm-crypt@saout.de \
--cc=gmazyland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox