From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E3EC433F5 for ; Fri, 29 Oct 2021 23:56:11 +0000 (UTC) Received: from mail.server123.net (mail.server123.net [78.46.64.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3230161038 for ; Fri, 29 Oct 2021 23:56:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3230161038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nwl.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=saout.de X-Virus-Scanned: amavisd-new at saout.de Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2001:41d0:e:133a::1; helo=orbyte.nwl.cc; envelope-from=n0-1@orbyte.nwl.cc; receiver= X-Greylist: delayed 1021 seconds by postgrey-1.37 at siona; Fri, 29 Oct 2021 23:48:19 CEST Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.server123.net (Postfix) with ESMTPS for ; Fri, 29 Oct 2021 23:48:18 +0200 (CEST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1mgZT3-0007rI-0X; Fri, 29 Oct 2021 23:31:17 +0200 Date: Fri, 29 Oct 2021 23:31:17 +0200 From: Phil Sutter To: Milan Broz Message-ID: <20211029213117.GY1668@orbyte.nwl.cc> References: <20211027232933.7445-1-phil@nwl.cc> <08f502bf-d41a-6b6a-36f7-60b4bddc1497@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <08f502bf-d41a-6b6a-36f7-60b4bddc1497@gmail.com> Sender: X-MailFrom: n0-1@orbyte.nwl.cc X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dm-crypt.saout.de-0 Message-ID-Hash: AV55M2YJVNRUAQI5DK7KWEDRLYALR7H6 X-Message-ID-Hash: AV55M2YJVNRUAQI5DK7KWEDRLYALR7H6 X-Mailman-Approved-At: Sat, 30 Oct 2021 01:47:56 +0200 CC: dm-crypt@saout.de X-Mailman-Version: 3.3.2 Precedence: list Subject: [dm-crypt] Re: [cryptsetup PATCH] Make BitLocker support optional List-Id: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Milan, On Thu, Oct 28, 2021 at 09:14:10AM +0200, Milan Broz wrote: > Support for all formats is mandatory (the pain to support various kernel configuration is already enough), > so sorry, but I will not accept this patch. I can relate but in this case the default is enabled so unless someone really cares nothing changes. > Also you cannot disable commands on CLI this way, it breaks user interface. > (Command can fail, but must not dissappear.) Sounds doable, assuming the above is not a final NACK. ;) > What issues this solves have here? Why you cannot link it? On an embedded device with uClibc I need libiconv which is 1.4MB in size. I was hoping to avoid having to ship this rather large library. While it's awesome that cryptsetup now supports bitlk partitions, I don't think it will see much use on embedded devices (e.g. a small file server). > We use only some specific functions so the solution can be just to implement this internally. Converting passphrases to utf16 is mandatory for bitlk support, right? In general, I'm not sure if all this is feasible - libcryptsetup is already 1.9MB and maintaining a mini-iconv is error-prone and likely to remain mostly untested. Cheers, Phil _______________________________________________ dm-crypt mailing list -- dm-crypt@saout.de To unsubscribe send an email to dm-crypt-leave@saout.de