From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tom.eccles@codethink.co.uk>
Received: from imap1.codethink.co.uk (imap1.codethink.co.uk [176.9.8.82])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.server123.net (Postfix) with ESMTPS
 for <dm-crypt@saout.de>; Wed, 17 Jul 2019 19:48:18 +0200 (CEST)
From: Tom Eccles <tom.eccles@codethink.co.uk>
Message-ID: <40fa6a57-ac08-1f50-dbce-cadefcbf1ff4@codethink.co.uk>
Date: Wed, 17 Jul 2019 18:06:52 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: [dm-crypt] veritysetup forward error correction failure
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <https://www.saout.de/mailman/options/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <https://www.saout.de/pipermail/dm-crypt/>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <https://www.saout.de/mailman/listinfo/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=subscribe>
To: dm-crypt@saout.de
Cc: richardmaw@codethink.co.uk

Hello,

I have a question about veritysetup using forward error correction.

I created my dm-verity volume using

veritysetup --check-at-most-once --fec-device /dev/vdc --fec-roots 24 format
/dev/vdb1 /dev/vdd

Then I introduce a single bit error into /dev/vdb1.

If I then open the dm-verity device using

veritysetup --fec-device /dev/vdc --fec-roots 24 open /dev/vdb1 vroot
/dev/vdd <hash>

When I mount the device and inspect the corrupted file, the single bit error
cannot be corrected:
[  108.994804] device-mapper: verity-fec: 254:17: FEC 19300352: failed to
correct: -74
[  108.994834] device-mapper: verity: 254:17: data block 273411 is corrupted

However, if I verify the whole device using veritysetup it succeeds:

veritysetup --fec-device /dev/vdc --fec-roots 24 verify /dev/vdb1 /dev/vdd
<hash>
Verification failed at position 1119891456.
Verification of data area failed.
Found 1 repairable errors with FEC device

So I suspect that I have the wrong flags to veritysetup open. Can anybody
see where I am going wrong?

Thanks,
Tom