DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: Massimo Burcheri <massimo@burcheri.de>
Cc: dm-crypt@saout.de, Moji <lordmoji@gmail.com>
Subject: Re: [dm-crypt] Fwd: Incompatible LRW changes from 2.6.27 to 2.6.29?
Date: Sun, 11 Oct 2009 23:56:27 +0200	[thread overview]
Message-ID: <4AD2548B.7020703@redhat.com> (raw)
In-Reply-To: <200910112205.18769.massimo@burcheri.de>

On 10/11/2009 10:05 PM, Massimo Burcheri wrote:
> On Fr Oktober 9 2009 at 22:07, Moji wrote:
> 
>> I am running Gentoo 2.6.30-r4 and I don't seem to be able to
>> reproduce the problem, maybe I am not understanding it correctly.
>>
>> Here is what I tried.
> ...
> 
> Hi, thanks for your efforts. This also works for me on 2.6.30, but did 
> you try to create the LUKS Device on 2.6.27 and then switching to 
> 2.6.30 to open it? That's what is failing here.
> Even creating on 2.6.30 and opening on 2.6.27 doesn't work.
> 
> Then the platform here is PPC.

Short searching in git log show this patch

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=8eb2dfac41c71701bb741f496f0cb7b7e4a3c3f6
"It turns out that LRW has never worked properly on big endian."
and maybe also
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fd4609a8e00a867303783ade62d67953fb72adc8

So I think since 2.6.29-rc6 it "work properly" and in previous kernel all ciphers
in LRW mode on big-endian arch produce wrong output.

Can you try to apply this simple patch(es) to old kernel and then check if it works in new one?

Milan
--
mbroz@redhat.com

      reply	other threads:[~2009-10-11 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 17:34 [dm-crypt] Fwd: Incompatible LRW changes from 2.6.27 to 2.6.29? Massimo Burcheri
2009-10-09 11:55 ` Milan Broz
2009-10-09 12:26   ` Milan Broz
2009-10-09 20:07 ` Moji
2009-10-11 20:05   ` Massimo Burcheri
2009-10-11 21:56     ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD2548B.7020703@redhat.com \
    --to=mbroz@redhat.com \
    --cc=dm-crypt@saout.de \
    --cc=lordmoji@gmail.com \
    --cc=massimo@burcheri.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox