From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mbroz@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
	by mail.saout.de (Postfix) with ESMTP
	for <dm-crypt@saout.de>; Fri, 11 Dec 2009 12:59:12 +0100 (CET)
Message-ID: <4B22340B.8060500@redhat.com>
Date: Fri, 11 Dec 2009 12:59:07 +0100
From: Milan Broz <mbroz@redhat.com>
MIME-Version: 1.0
References: <4B2023F1.6050306@gmx.net> <20091211040619.GA6979@tansi.org>
	<4B22258A.4070009@gmx.net>
In-Reply-To: <4B22258A.4070009@gmx.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] Exhaustive key reading seems to silently stop
	on	error
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=subscribe>
To: "Nico R." <n-roeser@gmx.net>
Cc: dm-crypt@saout.de

On 12/11/2009 11:57 AM, Nico R. wrote:

>>> In lib/utils.c (line 450f. in cryptsetup-1.0.7; line 490f. in current
>>> SVN revision, r132, equal to r152), we see the following code:
>>>
>>> if(read(fd, pass + i, 1) != 1 || (newline_stop && pass[i] == '\n'))
>>>         break;
>>>
>>> If I interpret that snipped (and its surroundings) correctly, the code
>>> will read until EOF *or* until an error occurs.

yes, sure it is bug, thanks for reporting it.

Fixed in trunk now
http://code.google.com/p/cryptsetup/source/detail?r=154#

Milan
--
mbroz@redhat.com