From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gmazyland@gmail.com>
Received: from mail.saout.de ([127.0.0.1])
 by localhost (mail.saout.de [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id tk3kh7LGMQpr for <dm-crypt@saout.de>;
 Sat,  8 Dec 2012 01:35:31 +0100 (CET)
Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com
 [209.85.215.178])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mail.saout.de (Postfix) with ESMTPS
 for <dm-crypt@saout.de>; Sat,  8 Dec 2012 01:35:31 +0100 (CET)
Received: by mail-ea0-f178.google.com with SMTP id k11so449393eaa.37
 for <dm-crypt@saout.de>; Fri, 07 Dec 2012 16:35:31 -0800 (PST)
Message-ID: <50C28B4F.3010801@gmail.com>
Date: Sat, 08 Dec 2012 01:35:27 +0100
From: Milan Broz <gmazyland@gmail.com>
MIME-Version: 1.0
References: <CAFnMBaTvK78M1WGrMEwD+Ap_7n+sdrZt1i7U1Nj9kxM7BP0-VQ@mail.gmail.com>
In-Reply-To: <CAFnMBaTvK78M1WGrMEwD+Ap_7n+sdrZt1i7U1Nj9kxM7BP0-VQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] crypt_load() crash when 3 argument is NULL
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt/>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=subscribe>
To: ".. ink .." <mhogomchungu@gmail.com>
Cc: dm-crypt@saout.de

On 12/08/2012 01:06 AM, .. ink .. wrote:
> This is something i noticed last night but forgot to mention in my previous email.
> 
> Just updated from git to test and the behavior is still there.
> 
> calling crypt_load() with the third argument as NULL segfaults.

params is required for TCRYPT type (you need to provide password/keyfiles here).

Should be fixed in git to return EINVAL instead, thanks.
(I'll revisit docs later, still a lot of other changes ahead.)

Milan