From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.saout.de ([127.0.0.1]) by localhost (mail.saout.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYFC7HvN2069 for ; Thu, 14 Nov 2013 08:38:21 +0100 (CET) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.saout.de (Postfix) with ESMTPS for ; Thu, 14 Nov 2013 08:38:21 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id ey16so245602wid.7 for ; Wed, 13 Nov 2013 23:38:20 -0800 (PST) Message-ID: <52847DE8.70502@gmail.com> Date: Thu, 14 Nov 2013 08:38:16 +0100 From: Milan Broz MIME-Version: 1.0 References: <1384378037-13519-1-git-send-email-dreisner@archlinux.org> In-Reply-To: <1384378037-13519-1-git-send-email-dreisner@archlinux.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dm-crypt] [PATCH] libdevmapper: correctly compare major and minor versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Reisner Cc: dm-crypt@saout.de On 11/13/2013 10:27 PM, Dave Reisner wrote: > Previously, this code could incorrectly identify a version of crypt or > dm due to the way it compared versions. For example, if a feature was > gated on crypt version 1.5, it would disable the feature for crypt > version 2.2. Yes, intention was just simple version check. Anyway, in most cases code tries use feature, and only if it fails, it reports error about missing support (this should prevent issues on some systems with backported patches without module version changes). Anyway, patch applied, thanks! Milan