From: Milan Broz <gmazyland@gmail.com>
To: Werner Koch <wk@gnupg.org>
Cc: dm-crypt <dm-crypt@saout.de>, gcrypt-devel@gnupg.org
Subject: Re: [dm-crypt] Whirlpool in gcrypt <= 1.5.3 broken (if writes in chunks)?
Date: Sun, 19 Jan 2014 20:49:41 +0100 [thread overview]
Message-ID: <52DC2C55.4020701@gmail.com> (raw)
In-Reply-To: <87fvokys88.fsf@vigenere.g10code.de>
On 01/19/2014 03:13 PM, Werner Koch wrote:
> On Fri, 17 Jan 2014 21:58, gmazyland@gmail.com said:
>
>> So if there is a "bug emulation flag" it could help to implement it.
>
> Done in master. The code is not very sophisticated: I added the flag and
> then re-added most of the old code. If this works out for you I
> will backport it to 1.6 and release a 1.6.1 soon.
It works, thanks! Please could you also add pbkdf2 speed fix to 1.6.1?
Because cryptsetup supports several backends (where this flawed whirlpool
was never present), I won't do any automatic repairs but instead I added
internal "whirlpool_gcryptbug" hash name to gcrypt cryptsetup backend
(which uses this flag with gcrypt > 1.6.0)
This will allow people to use it if really needed.
Thanks,
Milan
next prev parent reply other threads:[~2014-01-19 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:25 [dm-crypt] Whirlpool in gcrypt <= 1.5.3 broken (if writes in chunks)? Milan Broz
2014-01-17 20:26 ` Werner Koch
2014-01-17 20:58 ` Milan Broz
2014-01-19 14:13 ` Werner Koch
2014-01-19 19:49 ` Milan Broz [this message]
2014-01-20 7:56 ` Werner Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DC2C55.4020701@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-crypt@saout.de \
--cc=gcrypt-devel@gnupg.org \
--cc=wk@gnupg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox