From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gmazyland@gmail.com>
Received: from mail-ee0-x22a.google.com (mail-ee0-x22a.google.com
 [IPv6:2a00:1450:4013:c00::22a])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mail.saout.de (Postfix) with ESMTPS
 for <dm-crypt@saout.de>; Fri,  7 Mar 2014 06:23:48 +0100 (CET)
Received: by mail-ee0-f42.google.com with SMTP id d17so1491126eek.15
 for <dm-crypt@saout.de>; Thu, 06 Mar 2014 21:23:47 -0800 (PST)
Message-ID: <531957DD.7020401@gmail.com>
Date: Fri, 07 Mar 2014 06:23:41 +0100
From: Milan Broz <gmazyland@gmail.com>
MIME-Version: 1.0
References: <5318DCEF.5020004@tu-ilmenau.de>
In-Reply-To: <5318DCEF.5020004@tu-ilmenau.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] goto patch for cryptsetup?
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt/>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=subscribe>
To: Lars Winterfeld <lars.winterfeld@tu-ilmenau.de>, dm-crypt@saout.de

On 03/06/2014 09:39 PM, Lars Winterfeld wrote:
> Hi,
> 
> in light of the latest "goto fail"s out there, would you reject a patch
> replacing all 328 gotos with their semantic equivalents from structured
> C programming?

cryptsetup code uss goto for only one purpose: to have only one exit
place from a function (with check for errors, release memory).

Replacing it with anything else means duplicating of lot of code.

Read e.g. kernel code, you will se the same patern on many places.

Milan