DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: "Thomas Bächler" <thomas@archlinux.org>,
	dm-crypt@saout.de, "Milan Broz" <gmazyland@gmail.com>
Subject: Re: [dm-crypt] libcryptsetup kernel feature detection fails on boot
Date: Wed, 23 Jul 2014 09:45:31 +0200	[thread overview]
Message-ID: <53CF681B.8030500@gmail.com> (raw)
In-Reply-To: <53CEE763.4030409@archlinux.org>

On 23.7.2014 0:36, Thomas Bächler wrote:
> Since cryptsetup 1.6.5, libcryptsetup fails to detect the kernel's
> features on boot. In particular, whenever the dm-crypt module is not
> loaded before configuring a mapping with libcryptsetup, the
> allow_discards option is not used.

Hm, yes, that's possible... dmcrypt is now needed only on activation
(previaously it was loaded earlier perhaps).

Well, the workaround for now is probably to always load dmcrypt module,
I'll try to fix it soon.

Milan

p.s.

FYI there are more problems discovered by the userspace header processing
in 1.6.5 (I expected these appears when introducing truecrypt format which
uses the same logic but unfortunately that was not the case).

- with SELinux in enforcing mode (and proper policy, in Fedora this applies
only to systemd-cryptsetup which is labeled as init process) it fails
to activate volumes.
Apparently kernel crypto API socket was never labeled properly(!)
(kernel selinux subsystem bug, patch on the way upstream).
See https://bugzilla.redhat.com/show_bug.cgi?id=1115120

- with some crazy configuration we hit the problem that some hash algorithm
are not available in userspace (whirlpool256 for example) so when
used in ESSIV it fails. There was conservative approach to fallback to old
mode, unfortunately I did not implement it correctly for this case.
See https://code.google.com/p/cryptsetup/issues/detail?id=222

So anyway, expect cryptsetup 1.6.6 to fix these...

  reply	other threads:[~2014-07-23  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 22:36 [dm-crypt] libcryptsetup kernel feature detection fails on boot Thomas Bächler
2014-07-23  7:45 ` Milan Broz [this message]
2014-07-24 20:20   ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CF681B.8030500@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=dm-crypt@saout.de \
    --cc=thomas@archlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox