DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Lefebvre <qlefebvre_pro@yahoo.com>
To: dm-crypt@saout.de
Subject: [dm-crypt] Empty key files vs empty passwords in plain mode
Date: Wed, 19 Nov 2014 22:24:45 +0100	[thread overview]
Message-ID: <546D0A9D.6080209@yahoo.com> (raw)

Hi,

I experienced some troubles recently with Debian's cryptsetup package 
(testing version), which version is 1.6.6.
I found out that empty key files get refused by cryptsetup, for example:
cat empty_file | cryptsetup --debug --key-file=- open --type plain 
/test1.loop test1
gets rejected.
The debug output directly leads to a test in utils_crypt.c that, I 
think, should be removed.

Indeed, empty passwords are accepted, so it make sense to accept also 
empty inputs.
Especially in Debian, where cryptdisks_start script calls:
/lib/cryptsetup/askpass | cryptsetup --key-file=- open --type [type] 
[src] [dst]

What do you think about this issue?
Shall I send a patch for that?

Best regards,
Quentin

PS: I checked against the git version, the problem is not solved and 
actually exactly the same.

             reply	other threads:[~2014-11-19 21:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 21:24 Quentin Lefebvre [this message]
2014-11-23 12:44 ` [dm-crypt] Empty key files vs empty passwords in plain mode Quentin Lefebvre
2014-11-23 13:16   ` Milan Broz
2014-11-23 14:01     ` Quentin Lefebvre
2014-11-23 14:57       ` Milan Broz
2014-11-23 15:29         ` Quentin Lefebvre
2014-11-23 15:33           ` Quentin Lefebvre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546D0A9D.6080209@yahoo.com \
    --to=qlefebvre_pro@yahoo.com \
    --cc=dm-crypt@saout.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox