DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: dm-crypt@saout.de
Subject: Re: [dm-crypt] [PATCH] include sys/sysmacros.h for major/minor/makedev
Date: Tue, 19 Apr 2016 11:06:52 +0200	[thread overview]
Message-ID: <5715F52C.7050200@gmail.com> (raw)
In-Reply-To: <20160419065344.GE5369@vapier.lan>

On 04/19/2016 08:53 AM, Mike Frysinger wrote:
> On 19 Apr 2016 08:34, Milan Broz wrote:
>> On 04/19/2016 08:16 AM, Mike Frysinger wrote:
...
>>> +#include <sys/sysmacros.h>
>>
>> Shouldn't we also check for existence of this header in autoconf?
>> I do not think it is present on all systems (FreeBSD?).
> 
> i couldn't tell how portable this code base was trying to be or if it
> was assuming Linux.  if you want to be portable w/autoconf, should be
> easy to do:
> (1) call AC_HEADER_MAJOR in configure.ac
> (2) use the idiom:
> #ifdef MAJOR_IN_MKDEV
> # include <sys/mkdev.h>
> #elif defined(MAJOR_IN_SYSMACROS)
> # include <sys/sysmacros.h>
> #endif

I fixed it with this commit
https://gitlab.com/cryptsetup/cryptsetup/commit/54c4b1656f93997ae5624051c91ea10249e5a823

Thanks,
Milan

  reply	other threads:[~2016-04-19  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19  6:16 [dm-crypt] [PATCH] include sys/sysmacros.h for major/minor/makedev Mike Frysinger
2016-04-19  6:34 ` Milan Broz
2016-04-19  6:53   ` Mike Frysinger
2016-04-19  9:06     ` Milan Broz [this message]
2016-04-19 15:22       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5715F52C.7050200@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=dm-crypt@saout.de \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox